Skip to content

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Dec 17, 2024

Contributes to #3201

Changes

Please provide a brief description of the changes here.

  • Upgrade to opentelemetry-proto 1.5.0

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 3242d82
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/67635ee2ba64b10008f6d991

@marcalff
Copy link
Member Author

@keith Please add a build for opentelemetry-proto 1.5.0 in bazel central.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.16%. Comparing base (92bf8da) to head (3242d82).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3210   +/-   ##
=======================================
  Coverage   88.16%   88.16%           
=======================================
  Files         198      198           
  Lines        6224     6224           
=======================================
  Hits         5487     5487           
  Misses        737      737           

@keith
Copy link
Contributor

keith commented Dec 17, 2024

bazelbuild/bazel-central-registry#3445

@marcalff marcalff marked this pull request as ready for review December 17, 2024 21:08
@marcalff marcalff requested a review from a team as a code owner December 17, 2024 21:08
@marcalff
Copy link
Member Author

Do not merge:

CI will fail for bazel, until the bazel central repository PR is merged.

@marcalff marcalff added pr:do-not-merge This PR is not ready to be merged. pr:please-review This PR is ready for review labels Dec 17, 2024
@marcalff marcalff removed the pr:do-not-merge This PR is not ready to be merged. label Dec 18, 2024
@marcalff marcalff merged commit 40d7b76 into open-telemetry:main Dec 19, 2024
57 checks passed
@santigimeno
Copy link
Contributor

Shouldn't https://github.com/open-telemetry/opentelemetry-cpp/blob/main/third_party_release have been updated too? If it should, I can open a PR.

@marcalff
Copy link
Member Author

Shouldn't https://github.com/open-telemetry/opentelemetry-cpp/blob/main/third_party_release have been updated too? If it should, I can open a PR.

@santigimeno Yes, thanks for spotting this.

PR welcome.

@marcalff marcalff deleted the upgrade_proto_1.5.0 branch February 5, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:please-review This PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants