Skip to content

Conversation

dbarker
Copy link
Member

@dbarker dbarker commented Aug 10, 2025

The cmake options (abi version, preview options, component options, ...) are set explicitly in many places for ci testing now.

This PR updates the ci/do_ci<.sh, .ps1> scripts to set the cmake options from the common test_common/cmake cache variable scripts.

Changes

  • update the do_ci scripts to use the common cmake cache scripts.
  • fix warnings caught by the windows maintainer mode build

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Copy link

netlify bot commented Aug 10, 2025

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 149c4bc
🔍 Latest deploy log https://app.netlify.com/projects/opentelemetry-cpp-api-docs/deploys/689a4ac6d085670008da0aaa

@dbarker dbarker marked this pull request as ready for review August 10, 2025 23:24
@dbarker dbarker requested a review from a team as a code owner August 10, 2025 23:24
Copy link

codecov bot commented Aug 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.03%. Comparing base (6aece9b) to head (149c4bc).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3582   +/-   ##
=======================================
  Coverage   90.03%   90.03%           
=======================================
  Files         220      220           
  Lines        7069     7069           
=======================================
  Hits         6364     6364           
  Misses        705      705           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice.

@lalitb lalitb merged commit 6e8a803 into open-telemetry:main Aug 12, 2025
94 of 100 checks passed
malkia added a commit to malkia/opentelemetry-cpp that referenced this pull request Aug 12, 2025
[CI] update do_ci scripts to use common cmake cache scripts (open-telemetry#3582)
@dbarker dbarker deleted the test_use_common_cmake_scripts_in_ci branch October 4, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants