Skip to content

[BUILD] upgrade googletest and benchmark to the latest releases supporting C++14 #3607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[BUILD] upgrade googletest and benchmark to the latest releases supporting C++14 #3607

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
876b1e7
upgrade googletest and benchmark to the latest releases
dbarker Aug 22, 2025
7734be9
roll back to googletest and benchmark versions that support c++14
dbarker Aug 23, 2025
eb893ee
Merge remote-tracking branch 'origin/main' into upgrade_googletest_an…
dbarker Sep 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,5 @@ bazel_dep(name = "protobuf", version = "26.0", repo_name = "com_google_protobuf"
bazel_dep(name = "rules_proto", version = "5.3.0-21.7")
bazel_dep(name = "zlib", version = "1.3.1.bcr.1")

bazel_dep(name = "google_benchmark", version = "1.8.3", dev_dependency = True, repo_name = "com_github_google_benchmark")
bazel_dep(name = "googletest", version = "1.14.0.bcr.1", dev_dependency = True, repo_name = "com_google_googletest")
bazel_dep(name = "google_benchmark", version = "1.9.0", dev_dependency = True, repo_name = "com_github_google_benchmark")
Copy link
Member Author

@dbarker dbarker Aug 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason these changes are triggering the bazel asan test to fail on compilation.

One issue is that the 20250127.0 version of abseil is being pulled in which only supports c++17.

2025/08/23 20:46:19 Downloading https://releases.bazel.build/7.1.1/release/bazel-7.1.1-linux-x86_64...
Starting local Bazel server and connecting to it...
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'com_google_absl', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph.
WARNING: For repository 'bazel_skylib', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph.
WARNING: For repository 'com_github_grpc_grpc', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph.
WARNING: For repository 'platforms', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph.
WARNING: For repository 'com_google_protobuf', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph.
WARNING: For repository 'rules_proto', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph.

bazel_dep(name = "googletest", version = "1.16.0", dev_dependency = True, repo_name = "com_google_googletest")
12 changes: 6 additions & 6 deletions bazel/repository.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@ def opentelemetry_cpp_deps():
maybe(
http_archive,
name = "com_github_google_benchmark",
sha256 = "6bc180a57d23d4d9515519f92b0c83d61b05b5bab188961f36ac7b06b0d9e9ce",
strip_prefix = "benchmark-1.8.3",
sha256 = "35a77f46cc782b16fac8d3b107fbfbb37dcd645f7c28eee19f3b8e0758b48994",
strip_prefix = "benchmark-1.9.0",
urls = [
"https://github.com/google/benchmark/archive/v1.8.3.tar.gz",
"https://github.com/google/benchmark/archive/v1.9.0.tar.gz",
],
)

Expand All @@ -37,10 +37,10 @@ def opentelemetry_cpp_deps():
maybe(
http_archive,
name = "com_google_googletest",
sha256 = "8ad598c73ad796e0d8280b082cebd82a630d73e73cd3c70057938a6501bba5d7",
strip_prefix = "googletest-1.14.0",
sha256 = "78c676fc63881529bf97bf9d45948d905a66833fbfa5318ea2cd7478cb98f399",
strip_prefix = "googletest-1.16.0",
urls = [
"https://github.com/google/googletest/archive/v1.14.0.tar.gz",
"https://github.com/google/googletest/archive/v1.16.0.tar.gz",
],
)

Expand Down
2 changes: 1 addition & 1 deletion third_party/benchmark
Open in desktop
Submodule benchmark updated 95 files
+0 −1 .clang-tidy
+4 −5 .github/install_bazel.sh
+1 −1 .github/libcxx-setup.sh
+2 −2 .github/workflows/bazel.yml
+1 −1 .github/workflows/build-and-test-min-cmake.yml
+1 −1 .github/workflows/build-and-test-perfcounters.yml
+55 −8 .github/workflows/build-and-test.yml
+4 −3 .github/workflows/clang-format-lint.yml
+1 −1 .github/workflows/clang-tidy.yml
+1 −1 .github/workflows/doxygen.yml
+38 −0 .github/workflows/pre-commit.yml
+0 −28 .github/workflows/pylint.yml
+1 −1 .github/workflows/sanitizer.yml
+8 −7 .github/workflows/test_bindings.yml
+45 −33 .github/workflows/wheels.yml
+1 −0 .gitignore
+18 −0 .pre-commit-config.yaml
+0 −208 .travis.yml
+99 −94 .ycm_extra_conf.py
+1 −0 AUTHORS
+41 −14 BUILD.bazel
+26 −15 CMakeLists.txt
+3 −0 CONTRIBUTORS
+27 −10 MODULE.bazel
+4 −6 README.md
+11 −9 WORKSPACE
+16 −19 bazel/benchmark_deps.bzl
+0 −3 bindings/python/BUILD
+0 −25 bindings/python/build_defs.bzl
+9 −16 bindings/python/google_benchmark/BUILD
+18 −39 bindings/python/google_benchmark/__init__.py
+13 −6 bindings/python/google_benchmark/benchmark.cc
+4 −1 bindings/python/google_benchmark/example.py
+7 −0 bindings/python/google_benchmark/version.py
+0 −17 bindings/python/nanobind.BUILD
+0 −6 bindings/python/python_headers.BUILD
+4 −0 cmake/Config.cmake.in
+4 −26 cmake/GetGitVersion.cmake
+1 −1 cmake/benchmark.pc.in
+7 −0 cmake/benchmark_main.pc.in
+4 −4 docs/python_bindings.md
+2 −4 docs/reducing_variance.md
+4 −14 docs/releasing.md
+53 −7 docs/user_guide.md
+84 −13 include/benchmark/benchmark.h
+38 −2 pyproject.toml
+125 −68 setup.py
+12 −2 src/CMakeLists.txt
+47 −8 src/benchmark.cc
+5 −4 src/benchmark_api_internal.cc
+2 −1 src/benchmark_api_internal.h
+3 −2 src/benchmark_register.cc
+2 −2 src/benchmark_register.h
+57 −32 src/benchmark_runner.cc
+5 −0 src/benchmark_runner.h
+3 −3 src/colorprint.cc
+29 −18 src/complexity.cc
+9 −5 src/console_reporter.cc
+2 −2 src/counter.cc
+11 −3 src/csv_reporter.cc
+27 −14 src/cycleclock.h
+1 −5 src/internal_macros.h
+7 −0 src/json_reporter.cc
+6 −4 src/perf_counters.cc
+10 −5 src/statistics.cc
+1 −1 src/string_util.cc
+37 −21 src/sysinfo.cc
+17 −5 src/timers.cc
+28 −1 src/timers.h
+5 −0 test/BUILD
+52 −40 test/CMakeLists.txt
+1 −1 test/basic_test.cc
+1 −1 test/benchmark_gtest.cc
+26 −0 test/benchmark_test.cc
+101 −59 test/complexity_test.cc
+2 −2 test/diagnostics_test.cc
+1 −1 test/link_main_test.cc
+1 −1 test/memory_manager_test.cc
+1 −0 test/output_test_helper.cc
+1 −1 test/perf_counters_gtest.cc
+1 −1 test/perf_counters_test.cc
+50 −0 test/profiler_manager_test.cc
+7 −4 test/reporter_output_test.cc
+1 −1 test/skip_with_error_test.cc
+2 −2 test/statistics_gtest.cc
+6 −3 test/user_counters_tabular_test.cc
+7 −7 test/user_counters_test.cc
+3 −2 tools/BUILD.bazel
+261 −170 tools/compare.py
+18 −0 tools/gbench/Inputs/test5_run0.json
+18 −0 tools/gbench/Inputs/test5_run1.json
+4 −4 tools/gbench/__init__.py
+1,071 −653 tools/gbench/report.py
+71 −43 tools/gbench/util.py
+65 −53 tools/strip_asm.py
2 changes: 1 addition & 1 deletion third_party/googletest
Open in desktop
Submodule googletest updated 87 files
+0 −43 .github/workflows/gtest-ci.yml
+1 −0 .gitignore
+30 −13 BUILD.bazel
+11 −2 CMakeLists.txt
+4 −4 CONTRIBUTING.md
+1 −0 CONTRIBUTORS
+76 −0 MODULE.bazel
+9 −13 README.md
+47 −13 WORKSPACE
+35 −0 WORKSPACE.bzlmod
+7 −5 ci/linux-presubmit.sh
+2 −1 ci/macos-presubmit.sh
+8 −3 ci/windows-presubmit.bat
+77 −61 docs/advanced.md
+18 −39 docs/faq.md
+48 −13 docs/gmock_cook_book.md
+4 −2 docs/gmock_for_dummies.md
+19 −20 docs/primer.md
+23 −30 docs/quickstart-bazel.md
+10 −3 docs/reference/assertions.md
+1 −2 docs/reference/mocking.md
+25 −4 docs/reference/testing.md
+61 −0 fake_fuchsia_sdk.bzl
+14 −13 googlemock/CMakeLists.txt
+3 −3 googlemock/README.md
+87 −24 googlemock/include/gmock/gmock-actions.h
+5 −4 googlemock/include/gmock/gmock-function-mocker.h
+214 −146 googlemock/include/gmock/gmock-matchers.h
+8 −6 googlemock/include/gmock/gmock-more-actions.h
+4 −6 googlemock/include/gmock/gmock-spec-builders.h
+8 −7 googlemock/include/gmock/gmock.h
+8 −6 googlemock/include/gmock/internal/gmock-internal-utils.h
+5 −4 googlemock/include/gmock/internal/gmock-port.h
+4 −4 googlemock/src/gmock-cardinalities.cc
+3 −2 googlemock/src/gmock-internal-utils.cc
+14 −15 googlemock/src/gmock-matchers.cc
+2 −1 googlemock/src/gmock-spec-builders.cc
+52 −4 googlemock/test/gmock-actions_test.cc
+2 −2 googlemock/test/gmock-function-mocker_test.cc
+27 −27 googlemock/test/gmock-matchers-arithmetic_test.cc
+71 −5 googlemock/test/gmock-matchers-comparisons_test.cc
+29 −11 googlemock/test/gmock-matchers-containers_test.cc
+82 −23 googlemock/test/gmock-matchers-misc_test.cc
+39 −1 googlemock/test/gmock-more-actions_test.cc
+1 −1 googlemock/test/gmock-pp_test.cc
+1 −1 googlemock/test/gmock-spec-builders_test.cc
+9 −0 googlemock/test/gmock_link_test.h
+14 −14 googletest/CMakeLists.txt
+2 −2 googletest/README.md
+4 −0 googletest/cmake/Config.cmake.in
+22 −20 googletest/cmake/internal_utils.cmake
+1 −1 googletest/include/gtest/gtest-assertion-result.h
+4 −4 googletest/include/gtest/gtest-death-test.h
+3 −3 googletest/include/gtest/gtest-matchers.h
+9 −10 googletest/include/gtest/gtest-message.h
+4 −4 googletest/include/gtest/gtest-param-test.h
+102 −27 googletest/include/gtest/gtest-printers.h
+65 −61 googletest/include/gtest/gtest-typed-test.h
+36 −19 googletest/include/gtest/gtest.h
+25 −26 googletest/include/gtest/internal/gtest-death-test-internal.h
+7 −1 googletest/include/gtest/internal/gtest-filepath.h
+30 −69 googletest/include/gtest/internal/gtest-internal.h
+79 −75 googletest/include/gtest/internal/gtest-param-util.h
+2 −0 googletest/include/gtest/internal/gtest-port-arch.h
+106 −43 googletest/include/gtest/internal/gtest-port.h
+3 −3 googletest/include/gtest/internal/gtest-type-util.h
+19 −17 googletest/src/gtest-death-test.cc
+1 −1 googletest/src/gtest-filepath.cc
+29 −17 googletest/src/gtest-internal-inl.h
+70 −28 googletest/src/gtest-port.cc
+243 −152 googletest/src/gtest.cc
+0 −1 googletest/test/BUILD.bazel
+1 −0 googletest/test/googletest-color-test.py
+41 −37 googletest/test/googletest-death-test-test.cc
+110 −16 googletest/test/googletest-json-output-unittest.py
+4 −1 googletest/test/googletest-options-test.cc
+0 −5 googletest/test/googletest-output-test-golden-lin.txt
+3 −3 googletest/test/googletest-port-test.cc
+40 −0 googletest/test/googletest-printers-test.cc
+52 −44 googletest/test/gtest_environment_test.cc
+23 −41 googletest/test/gtest_help_test.py
+3 −0 googletest/test/gtest_json_test_utils.py
+1 −3 googletest/test/gtest_repeat_test.cc
+68 −27 googletest/test/gtest_unittest.cc
+76 −32 googletest/test/gtest_xml_output_unittest.py
+21 −1 googletest/test/gtest_xml_output_unittest_.cc
+16 −10 googletest_deps.bzl
4 changes: 2 additions & 2 deletions third_party_release
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ zlib=v1.3.1
curl=curl-8_12_0
protobuf=v3.21.6
grpc=v1.49.2
benchmark=v1.8.3
googletest=v1.14.0
benchmark=v1.9.0
googletest=v1.16.0
ms-gsl=v3.1.0
nlohmann-json=v3.12.0
opentelemetry-proto=v1.7.0
Expand Down
Loading