Skip to content

Conversation

keith
Copy link
Contributor

@keith keith commented Oct 16, 2025

Bazel 7.x (the current minimum supported version) supports using this
repo with bzlmod. With bazel 9.x coming out next month, it doesn't
support WORKSPACE anymore. It's getting quite hard to support both of
these versions at once as many rules repos no longer test WORKSPACE
support.

@keith keith requested a review from a team as a code owner October 16, 2025 18:59
Bazel 7.x (the current minimum supported version) supports using this
repo with bzlmod. With bazel 9.x coming out next month, it doesn't
support WORKSPACE anymore. It's getting quite hard to support both of
these versions at once as many rules repos no longer test WORKSPACE
support.
@keith keith force-pushed the ks/drop-workspace-support branch from 00fd5a3 to f242c66 Compare October 16, 2025 19:00
@keith keith changed the title Drop WORKSPACE support [bazel] Drop WORKSPACE support Oct 16, 2025
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.94%. Comparing base (767ef30) to head (f242c66).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3699      +/-   ##
==========================================
- Coverage   89.95%   89.94%   -0.01%     
==========================================
  Files         225      225              
  Lines        7273     7273              
==========================================
- Hits         6542     6541       -1     
- Misses        731      732       +1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the cleanup.

@marcalff
Copy link
Member

CI failures are unrelated.

@marcalff
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants