Skip to content

Conversation

ShapovalovaIrina
Copy link
Contributor

@ShapovalovaIrina ShapovalovaIrina commented Feb 20, 2025

Conform attributes and span name to v1.27 semantics for OpentelemetryFinch.

Follows the guidelines set out in https://github.com/open-telemetry/semantic-conventions/blob/v1.27.0/docs/http/http-spans.md.

Changed

Span name

  • Change default span name HTTP {method} -> {method}

Required attributes

  • Set error.type attribute when span status is error
  • Rename attribute http.method -> http.request.method
  • Rename attribute http.url -> url.full
  • Rename attribute http.status_code -> http.response.status_code
  • Rename attribute net.host.name -> server.address

Opt-in attributes

  • Rename attribute http.scheme -> url.scheme

Added

Span name

  • Add :span_name option for custom value
  • Add :url_template option for {method} {url_template} span name

Required attributes

  • Add attribute server.port

Opt-in attributes

  • Add attribute http.request.body.size
  • Add attribute http.response.body.size
  • Add attribute network.transport
  • Add attribute url.template
  • Add attribute user.agent.original
  • Add attribute http.request.header.<key>
  • Add attribute http.request.header.<key>

The presence of opt-in attributes is configured using options:

  • :opt_in_attrs
  • :request_header_attrs
  • :response_header_attrs

Other

  • Set span status to error, when HTTP status code is in 4xx or 5xx

Removed

  • Remove attribute http.target

@ShapovalovaIrina ShapovalovaIrina marked this pull request as draft February 21, 2025 12:45
@ShapovalovaIrina ShapovalovaIrina force-pushed the update-opentelemetry-finch-to-1.27-semantics branch 2 times, most recently from b90fafa to a743d13 Compare February 24, 2025 13:50
@ShapovalovaIrina ShapovalovaIrina marked this pull request as ready for review February 24, 2025 14:10
@ShapovalovaIrina ShapovalovaIrina force-pushed the update-opentelemetry-finch-to-1.27-semantics branch from a743d13 to 575e055 Compare February 26, 2025 08:12
@ShapovalovaIrina
Copy link
Contributor Author

@bryannaegele Hello! Sorry for bothering you, I couldn't find any information about who is opentelemetry_finch codeowner, so I'm contacting you. Can you please tag the right person or leave some feedback on PR?

@bryannaegele
Copy link
Contributor

Hey @ShapovalovaIrina , this is great!

Two requests:

  • list out the aliases as fully qualified (makes it easier to find references during updates)
  • use the semantic conventions for matches in tests so we don't have to know the values of the keys - example

@ShapovalovaIrina ShapovalovaIrina marked this pull request as draft May 5, 2025 16:02
@ShapovalovaIrina ShapovalovaIrina force-pushed the update-opentelemetry-finch-to-1.27-semantics branch from 9147783 to 6df8de9 Compare May 20, 2025 14:21
@ShapovalovaIrina ShapovalovaIrina marked this pull request as ready for review May 20, 2025 14:23
@ShapovalovaIrina
Copy link
Contributor Author

Two requests:

  • list out the aliases as fully qualified (makes it easier to find references during updates)
  • use the semantic conventions for matches in tests so we don't have to know the values of the keys - example

@bryannaegele made the changes that were requested :)

Similar changes have also been made for OpentelemetryTesla PR #469.

@ShapovalovaIrina ShapovalovaIrina force-pushed the update-opentelemetry-finch-to-1.27-semantics branch from 6df8de9 to f83552e Compare July 3, 2025 11:14
@ShapovalovaIrina
Copy link
Contributor Author

Hi @bryannaegele, do you have an estimate for when you might be able to take a look at this? No rush, just wanted to check 🙂 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants