Conform attributes and span name to v1.27 semantics for OpentelemetryFinch #470
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conform attributes and span name to v1.27 semantics for OpentelemetryFinch.
Follows the guidelines set out in https://github.com/open-telemetry/semantic-conventions/blob/v1.27.0/docs/http/http-spans.md.
Changed
Span name
HTTP {method}
->{method}
Required attributes
error.type
attribute when span status is errorhttp.method
->http.request.method
http.url
->url.full
http.status_code
->http.response.status_code
net.host.name
->server.address
Opt-in attributes
http.scheme
->url.scheme
Added
Span name
:span_name
option for custom value:url_template
option for{method} {url_template}
span nameRequired attributes
server.port
Opt-in attributes
http.request.body.size
http.response.body.size
network.transport
url.template
user.agent.original
http.request.header.<key>
http.request.header.<key>
The presence of opt-in attributes is configured using options:
:opt_in_attrs
:request_header_attrs
:response_header_attrs
Other
Removed
http.target