Add linter checking we use the latest semconv version #8231
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmathieu
added
the
Skip Changelog
mx-psi
approved these changes
Nov 28, 2025
| list-mode: lax | ||
| deny: | ||
| - pkg: go.opentelemetry.io/otel/semconv | ||
| desc: Use go.opentelemetry.io/otel/semconv/v1.37.0 instead. If a newer semconv version has been released, update the depguard rule. |
There was a problem hiding this comment.
Same comment as I made on collector.
Suggested change
| desc: Use go.opentelemetry.io/otel/semconv/v1.37.0 instead. If a newer semconv version has been released, update the depguard rule. | |
| desc: Use go.opentelemetry.io/otel/semconv/v1.38.0 instead. When a newer semconv version is released, it must be added to the depguard rule. |
Or
Suggested change
| desc: Use go.opentelemetry.io/otel/semconv/v1.37.0 instead. If a newer semconv version has been released, update the depguard rule. | |
| desc: Use go.opentelemetry.io/otel/semconv/v1.38.0 instead. If a newer semconv version has been released, update the depguard rule. |
| desc: Use go.opentelemetry.io/otel/semconv/v1.37.0 instead. If a newer semconv version has been released, update the depguard rule. | ||
| allow: | ||
| - go.opentelemetry.io/otel/semconv/v1.21.0 # still used by otelmongo | ||
| - go.opentelemetry.io/otel/semconv/v1.37.0 |
There was a problem hiding this comment.
Suggested change
| - go.opentelemetry.io/otel/semconv/v1.37.0 | |
| - go.opentelemetry.io/otel/semconv/v1.37.0 | |
| - go.opentelemetry.io/otel/semconv/v1.38.0 |
Member
Author
There was a problem hiding this comment.
Upgrading to 1.38 makes sense. But it shouldn't be within this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is inspired by open-telemetry/opentelemetry-collector-contrib#44606
Mongo is the only package with an older semconv. See #8230 to move forward with the upgrade.