Skip to content

Conversation

@LikeTheSalad
Copy link
Contributor

@LikeTheSalad LikeTheSalad commented Mar 6, 2025

Description:

Creates a public configuration config package to place all the configuration-related files, including the TemporaryFileProvider type that was placed in an internal package by mistake.

Existing Issue(s):

#1772

Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. It's a good change....although I would have preferred io.opentelemetry.contrib.disk.buffering.config to io.opentelemetry.contrib.disk.buffering.configuration for brevity, but not a huge issue.

@LikeTheSalad
Copy link
Contributor Author

Thanks. It's a good change....although I would have preferred io.opentelemetry.contrib.disk.buffering.config to io.opentelemetry.contrib.disk.buffering.configuration for brevity, but not a huge issue.

Sounds good. I've made the change.

@trask trask merged commit 2b31033 into open-telemetry:main Mar 10, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants