Add missing EventName to disk-buffering LogRecordDataMapper #1950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doohl
force-pushed
the
feat/event-name-disk-buffering
branch
from
dbcca6c to
7743a2e
Compare
Doohl
commented
Jun 9, 2025
...etry/contrib/disk/buffering/internal/serialization/mapping/logs/ProtoLogsDataMapperTest.java
Show resolved
Hide resolved
breedx-splk
approved these changes
Jun 9, 2025
Contributor
breedx-splk
left a comment
breedx-splk
left a comment
There was a problem hiding this comment.
This looks good to me. Thanks for the contribution!
LikeTheSalad
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Updates disk-buffering to use the new EventName spec for LogRecords for both serialization to protobuf and de-serialization to SDK LogRecords.
Existing behavior is preserved; EventName will be excluded if it's not present in the data model.
Existing Issue(s):
Fixes #1938
Testing:
Documentation:
No documentation updates needed. We aren't introducing new behavior, but rather preserving the expected behavior.