Ensure all test suites are run #2344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔧 The result from spotlessApply was committed to the PR branch. |
github-actions
bot
requested review from
SylvainJuge,
breedx-splk and
robsunday
trask
commented
Oct 10, 2025
| otlpServer = new OtlpGrpcServer(); | ||
| otlpServer.start(); | ||
| Testcontainers.exposeHostPorts(otlpServer.httpPort()); | ||
| exposeHostPorts(otlpServer.httpPort()); |
There was a problem hiding this comment.
this change needed because of conflict with Testcontainers annotation in different package.
| import org.testcontainers.containers.output.Slf4jLogConsumer; | ||
| import org.testcontainers.junit.jupiter.Testcontainers; | ||
|
|
||
| @Testcontainers(disabledWithoutDocker = true) |
There was a problem hiding this comment.
this is needed because the Windows runners now run these tests (where only Windows containers are supported)
There was a problem hiding this comment.
Do these tests run on linux then? We need to make sure they run somewhere. Ideally on weekly basis at least.
...grationTest/java/io/opentelemetry/contrib/jmxscraper/target_systems/SolrIntegrationTest.java
Outdated
Show resolved
Hide resolved
…jmxscraper/target_systems/SolrIntegrationTest.java
trask
commented
Oct 11, 2025
...grationTest/java/io/opentelemetry/contrib/jmxmetrics/target_systems/SolrIntegrationTest.java
Outdated
Show resolved
Hide resolved
…jmxmetrics/target_systems/SolrIntegrationTest.java
jaydeluca
approved these changes
Oct 14, 2025
Merged
via the queue into
open-telemetry:main
with commit Oct 14, 2025
e8e2b89
39 of 41 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing our reliance on specific
integrationTesttest suite name, and ensuring that all test suites are run as part ofcheck.Another benefit(?) is that integration tests are now run on the full Java version matrix that we support (the ? is because it may increase flakiness)