- 
                Notifications
    
You must be signed in to change notification settings  - Fork 168
 
Ensure all test suites are run #2344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 12 commits
1190b17
              fd7f972
              668e968
              3fff16d
              5f24847
              69efe20
              88d7f4e
              0bab357
              12c9126
              7e24306
              dc40365
              7247e18
              7df634e
              File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | 
|---|---|---|
| 
          
            
          
           | 
    @@ -7,6 +7,7 @@ | |
| 
     | 
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
| import static org.awaitility.Awaitility.await; | ||
| import static org.testcontainers.Testcontainers.exposeHostPorts; | ||
| 
     | 
||
| import com.linecorp.armeria.server.ServerBuilder; | ||
| import com.linecorp.armeria.server.grpc.GrpcService; | ||
| 
          
            
          
           | 
    @@ -35,11 +36,12 @@ | |
| import org.junit.jupiter.api.io.TempDir; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
| import org.testcontainers.Testcontainers; | ||
| import org.testcontainers.containers.GenericContainer; | ||
| import org.testcontainers.containers.Network; | ||
| import org.testcontainers.containers.output.Slf4jLogConsumer; | ||
| import org.testcontainers.junit.jupiter.Testcontainers; | ||
| 
     | 
||
| @Testcontainers(disabledWithoutDocker = true) | ||
| 
         There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is needed because the Windows runners now run these tests (where only Windows containers are supported) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do these tests run on linux then? We need to make sure they run somewhere. Ideally on weekly basis at least. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, they run on linux  | 
||
| public abstract class TargetSystemIntegrationTest { | ||
| private static final Logger logger = LoggerFactory.getLogger(TargetSystemIntegrationTest.class); | ||
| private static final Logger targetSystemLogger = LoggerFactory.getLogger("TargetSystemContainer"); | ||
| 
          
            
          
           | 
    @@ -72,7 +74,7 @@ static void beforeAll() { | |
| network = Network.newNetwork(); | ||
| otlpServer = new OtlpGrpcServer(); | ||
| otlpServer.start(); | ||
| Testcontainers.exposeHostPorts(otlpServer.httpPort()); | ||
| exposeHostPorts(otlpServer.httpPort()); | ||
| 
         There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this change needed because of conflict with   | 
||
| otlpEndpoint = "http://" + OTLP_HOST + ":" + otlpServer.httpPort(); | ||
| } | ||
| 
     | 
||
| 
          
            
          
           | 
    ||
Uh oh!
There was an error while loading. Please reload this page.