Skip to content

Conversation

@dol
Copy link
Contributor

@dol dol commented Oct 25, 2025

Description:

According to https://maven.apache.org/pom.html#SCM the scm.url should be a publicly browsable repository.
Replaced git URI with URL to project page on Github.

Added issueManagement and ciManagement information to the scm section.

Took inspiration from https://central.sonatype.com/artifact/org.apache.maven/maven/4.0.0-rc-4 and their pom.xml.

image

The link on https://central.sonatype.com/artifact/io.opentelemetry.contrib/opentelemetry-cel-sampler/1.51.0-alpha ends up in a 404.

image

Before the change

image

After the change

The new pom.xml would look like this. Generated with ./gradlew clean publishToMavenLocal.
The scm.url points to the release version of the source code.

image

@dol dol requested a review from a team as a code owner October 25, 2025 14:44
@trask
Copy link
Member

trask commented Oct 25, 2025

makes sense to me 👍

The new pom.xml would look like this. Generated with ./gradlew clean publishToMavenLocal. The scm.url points to the release version of the source code.

image

this repos's tags don't have -alpha and start with v, e.g. https://github.com/open-telemetry/opentelemetry-java-contrib/tree/v1.51.0

According to https://maven.apache.org/pom.html#SCM the `scm.url` should
be a publicly browsable repository.
Replaced git URI with URL to project page on Github.

Added `issueManagement` and `ciManagement` information to the scm
section.
@dol dol force-pushed the chore/update-scm-url branch from c296ad2 to 36435d4 Compare October 25, 2025 20:42
@dol
Copy link
Contributor Author

dol commented Oct 25, 2025

makes sense to me 👍

The new pom.xml would look like this. Generated with ./gradlew clean publishToMavenLocal. The scm.url points to the release version of the source code.

this repos's tags don't have -alpha and start with v, e.g. https://github.com/open-telemetry/opentelemetry-java-contrib/tree/v1.51.0

Good point. The new approach will reference the stableVersion from the version.gradle.kts. Emulated a new release locally by setting stableVersion = 1.52.0.

image

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@open-telemetry/java-approvers @open-telemetry/java-instrumentation-approvers if this looks good, I'll port to the other Java repos after merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants