Skip to content

chore: Added more project links to the pom.xml #2386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −1
Open

chore: Added more project links to the pom.xml #2386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion buildSrc/src/main/kotlin/otel.publish-conventions.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ plugins {
signing
}

val tagVersion: String by rootProject.extra

publishing {
publications {
register<MavenPublication>("maven") {
Expand Down Expand Up @@ -55,7 +57,18 @@ publishing {
scm {
connection.set("scm:git:[email protected]:open-telemetry/opentelemetry-java-contrib.git")
developerConnection.set("scm:git:[email protected]:open-telemetry/opentelemetry-java-contrib.git")
url.set("[email protected]:open-telemetry/opentelemetry-java-contrib.git")
tag.set(tagVersion)
url.set("https://github.com/open-telemetry/opentelemetry-java-contrib/tree/${tagVersion}")
Comment on lines +60 to +61
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these probably aren't correct for snapshot builds, does that matter?

}

issueManagement {
system.set("GitHub Issues")
url.set("https://github.com/open-telemetry/opentelemetry-java-contrib/issues")
}

ciManagement {
system.set("GitHub Actions")
url.set("https://github.com/open-telemetry/opentelemetry-java-contrib/actions")
}

withXml {
Expand Down
1 change: 1 addition & 0 deletions version.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
val stableVersion = "1.52.0-SNAPSHOT"
val alphaVersion = "1.52.0-alpha-SNAPSHOT"
val tagVersion by extra { "v$stableVersion" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not make this a local variable if its only used in otel.publish-conventions.gradle.kts?


allprojects {
if (findProperty("otel.stable") != "true") {
Expand Down