Skip to content

Conversation

@trask
Copy link
Member

@trask trask commented Dec 4, 2024

😢

TODO delete GRADLE_ENTERPRISE_ACCESS_KEY github action secret after merging this

@trask trask requested a review from a team as a code owner December 4, 2024 19:43
@github-actions github-actions bot requested a review from theletterf December 4, 2024 19:43
// This value is quite big because with lower values (3 mins) we were experiencing large number of false positives
timeout.set(Duration.ofMinutes(15))

develocity.testRetry {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this will force us to deal with the flaky tests. Can always add it back if there are too many build failures.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I was worried about us never seeing flaky tests if we don't remove it, but I realized a better option is probably to only disable retries on the daily builds in order to not disrupt other workflows (PRs / releases), will update this PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated this PR, can you give it one more look now? thanks

@trask trask merged commit 80ccda1 into open-telemetry:main Dec 7, 2024
56 checks passed
@trask trask deleted the update-develocity-config branch December 7, 2024 15:36
@trask trask mentioned this pull request Dec 7, 2024
trask added a commit to trask/opentelemetry-java-instrumentation that referenced this pull request Oct 17, 2025
@trask trask mentioned this pull request Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants