Static import semconv constants in tests

[trask]

I was looking into scraping the code to verify that all inlined constants are tested (via non-inlined constants):

open-telemetry/opentelemetry-java-contrib#1604 (comment)

and this normalizing will help my grepping efforts

tracking my latest script:

#!/bin/bash -e

for file in $(find instrumentation -name '*Test.java'); do
  echo "Processing $file"

  # stable semconv

  negative_lookbehind='(?<!import static io.opentelemetry.semconv.)'

  for class in "ClientAttributes" "ErrorAttributes" "ExceptionAttributes" "HttpAttributes" "JvmAttributes" "NetworkAttributes" "OtelAttributes" "ServerAttributes" "ServiceAttributes" "TelemetryAttributes" "UrlAttributes" "UserAgentAttributes"; do
    for attr in $(perl -ne "print \"\$1\n\" if /$negative_lookbehind$class\.([A-Z][A-Z][A-Z_]*)/" $file | sort -u); do
      perl -i -pe "s/$negative_lookbehind$class\.$attr/$attr/" $file
      sed -i "0,/^import/{s/^import/import static io.opentelemetry.semconv.$class.$attr;\nimport/}" $file
    done
  done

  # incubating semconv

  negative_lookbehind='(?<!import static io.opentelemetry.semconv.incubating.)'

  for class in "AwsIncubatingAttributes" "DbIncubatingAttributes" "HttpIncubatingAttributes" "MessagingIncubatingAttributes"; do
    for attr in $(perl -ne "print \"\$1\n\" if /$negative_lookbehind$class\.([A-Z][A-Z][A-Z_]*)/" $file | sort -u); do
      perl -i -pe "s/$negative_lookbehind$class\.$attr/$attr/" $file
      sed -i "0,/^import/{s/^import/import static io.opentelemetry.semconv.incubating.$class.$attr;\nimport/}" $file
    done
  done
done

./gradlew spotlessApply

[zeitlinger]

have you tried using this approach?

https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/12009/files#diff-b36b9b7d4939f00472feba2fd8ee942cec0591677a9b7a8220b6770ba1cd2fadR53-R64

[trask]

have you tried using this approach?

https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/12009/files#diff-b36b9b7d4939f00472feba2fd8ee942cec0591677a9b7a8220b6770ba1cd2fadR53-R64

I'm not quite ready to enforce it, maybe after we finish migrating all of the groovy tests

[laurit]

DB_NAME isn't the only deprecate attribute used here, maybe reword the comment?