fix semconv naming for 'jvm.buffer.memory.used' metric #13374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
approved these changes
Feb 21, 2025
steverao
approved these changes
Feb 24, 2025
…nstrumentation into jvm-buffer-metric-semconv
github-actions
bot
added
the
test native
laurit
approved these changes
Feb 25, 2025
kcsurapaneni
pushed a commit
to kcsurapaneni/opentelemetry-java-instrumentation
that referenced
this pull request
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the stable and experimental JVM metrics were introduced with release 2.0.0, the
jvm.buffer.memory.usagemetric was not properly renamed tojvm.buffer.memory.usedand thus does not fit the expected semantic conventions.This PR renames the metric to fit the definition in semantic conventions.
This is still an experimental metric, and while there hasn't had any bug report of this inconsistency in about a year, it's technically a breaking change.