-
Notifications
You must be signed in to change notification settings - Fork 986
declarative config: early init and property mapping #14184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
declarative config: early init and property mapping #14184
Conversation
...in/java/io/opentelemetry/javaagent/tooling/config/DeclarativeConfigEarlyInitAgentConfig.java
Outdated
Show resolved
Hide resolved
...in/java/io/opentelemetry/javaagent/tooling/config/DeclarativeConfigEarlyInitAgentConfig.java
Outdated
Show resolved
Hide resolved
...pi/src/main/java/io/opentelemetry/javaagent/extension/DeclarativeConfigPropertiesBridge.java
Outdated
Show resolved
Hide resolved
ea7fdfd
to
a36770e
Compare
...in/java/io/opentelemetry/javaagent/tooling/config/DeclarativeConfigEarlyInitAgentConfig.java
Outdated
Show resolved
Hide resolved
...nt-tooling/src/main/java/io/opentelemetry/javaagent/tooling/config/EarlyInitAgentConfig.java
Outdated
Show resolved
Hide resolved
This still leaves "otel.javaagent.enabled" - which promises not to touch anything if the value is |
https://github.com/open-telemetry/opentelemetry-java/blob/main/sdk-extensions/incubator/src/main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/DeclarativeConfiguration.java doesn't log for the method that we call - but jackson can throw exceptions (which I can buffer like |
How can we find out if that's the case? E.g. a tool to compare loaded classes against what we want to transform. |
extracted ErrorBuffer: https://github.com/zeitlinger/opentelemetry-java-instrumentation/blob/eb8ee1978206d602db9e07b02e09b36e01d3cad3/javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/config/ErrorBuffer.java |
@laurit please have a look 😄 |
3524434
to
682b5e0
Compare
...t-extension-api/src/main/java/io/opentelemetry/javaagent/extension/ConfigPropertiesUtil.java
Outdated
Show resolved
Hide resolved
...pi/src/main/java/io/opentelemetry/javaagent/extension/DeclarativeConfigPropertiesBridge.java
Outdated
Show resolved
Hide resolved
...tooling/src/test/groovy/io/opentelemetry/javaagent/tooling/OpenTelemetryInstallerTest.groovy
Show resolved
Hide resolved
.../test/java/io/opentelemetry/javaagent/tooling/config/OtlpProtocolPropertiesSupplierTest.java
Show resolved
Hide resolved
1e27b90
to
548e56c
Compare
🔧 The result from spotlessApply was committed to the PR branch. |
811b037
to
b0c18d3
Compare
@laurit please check again |
...va/io/opentelemetry/instrumentation/api/incubator/config/internal/InstrumentationConfig.java
Outdated
Show resolved
Hide resolved
...va/io/opentelemetry/instrumentation/api/incubator/config/internal/InstrumentationConfig.java
Outdated
Show resolved
Hide resolved
This reverts commit 643b8f8.
a8aeebf
to
413ec6d
Compare
Fixes #14133
Fixes #14132
Fixes #14160
Integration test already existed before:
opentelemetry-java-instrumentation/instrumentation/methods/javaagent/build.gradle.kts
Lines 22 to 36 in 4251217