Rename lambda instrumentation helper class #14371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
approved these changes
Aug 4, 2025
lukeina2z
added a commit
to aws-observability/aws-otel-java-instrumentation
that referenced
this pull request
Oct 27, 2025
This PR updates the upstream dependency OpenTelemetry Java Agent to their 2025 Sep. release version 2.20.1 (opentelemetry-instrumentation:2.20.1). By doing so, the following upstream OpenTelemetry dependencies are automatically updated along with the Java Agent: opentelemetry-api: 1.54.1 opentelemetry-sdk: 1.54.1 opentelemetry-semconv: 1.37.0 Conflicts between the ADOT patch and the two upstream PRs below are resolved in this PR. Rename lambda instrumentation helper class open-telemetry/opentelemetry-java-instrumentation#14371 Let AWS Lambda SQS handlers report partial batch failures open-telemetry/opentelemetry-java-instrumentation#14468 Tests Performed Unit tests: ./gradlew build test Smoke/contract tests: ./gradlew appsignals-tests:contract-tests:contractTests Manual E2E tests: Spring Boot EC2 sample app Java Lambda function Spring Boot web application hosted on AWS Lambda By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was reading the code in these modules and noticed they didn't follow the standard pattern of using a
Singletonsclass for the instrumenters, so I renamed the helper classes to follow that pattern. Also cleaned up some test code visibility.