-
Notifications
You must be signed in to change notification settings - Fork 1k
Metadata for aws lambda events 3.11 #14514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
866d03a
metadata for new aws lambda events
jaydeluca da5decf
Update descriptions
jaydeluca b56b157
Merge branch 'main' into metadata-lambda-3
jaydeluca 903bb90
update core desc
jaydeluca 55b6534
update core desc
jaydeluca a8da39e
pr review updates
jaydeluca 2814cc8
Merge branch 'main' of github.com:jaydeluca/opentelemetry-java-instru…
jaydeluca File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -923,6 +923,7 @@ libraries: | |
| - name: aws-lambda-core-1.0 | ||
| description: | | ||
| Provides lightweight instrumentation of the Lambda core library, supporting all versions. It generates FaaS SERVER spans with the `faas.invocation_id` attribute. Use this package if you only use `RequestStreamHandler` or know you don't use any event classes from `aws-lambda-java-events`. This also includes when you are using `aws-serverless-java-container` to run e.g., a Spring Boot application on Lambda. | ||
| For custom wrappers when using library instrumentation, you can configure the `OTEL_INSTRUMENTATION_AWS_LAMBDA_HANDLER` env property to your lambda handler method in following format `package.ClassName::methodName` and use one of wrappers as your lambda `Handler`. | ||
| source_path: instrumentation/aws-lambda/aws-lambda-core-1.0 | ||
| scope: | ||
| name: io.opentelemetry.aws-lambda-core-1.0 | ||
|
|
@@ -945,7 +946,7 @@ libraries: | |
| type: STRING | ||
| - name: aws-lambda-events-2.2 | ||
| description: | | ||
| Provides full instrumentation of the Lambda library, including standard and custom event types, from `aws-lambda-java-events` 2.2+. | ||
| This version of the library instrumentation is deprecated, please use the aws-lambda-events-3.11 library instrumentation instead. This instrumentation builds on top of the lightweight `aws-lambda-core-1.0` instrumentation, expanding support to cover the Lambda library, including standard and custom event types. | ||
|
||
| source_path: instrumentation/aws-lambda/aws-lambda-events-2.2 | ||
| scope: | ||
| name: io.opentelemetry.aws-lambda-events-2.2 | ||
|
|
@@ -960,6 +961,11 @@ libraries: | |
| description: Flush timeout in milliseconds. | ||
| type: int | ||
| default: 10000 | ||
| - name: otel.instrumentation.http.known-methods | ||
| description: | | ||
| Configures the instrumentation to recognize an alternative set of HTTP request methods. All other methods will be treated as `_OTHER`. | ||
| type: list | ||
| default: CONNECT,DELETE,GET,HEAD,OPTIONS,PATCH,POST,PUT,TRACE | ||
| telemetry: | ||
| - when: default | ||
| spans: | ||
|
|
@@ -984,13 +990,51 @@ libraries: | |
| - name: user_agent.original | ||
| type: STRING | ||
| - name: aws-lambda-events-3.11 | ||
| description: | | ||
| This instrumentation builds on top of the lightweight `aws-lambda-core-1.0` instrumentation, expanding support to cover the Lambda library, including standard and custom event types. | ||
| source_path: instrumentation/aws-lambda/aws-lambda-events-3.11 | ||
| scope: | ||
| name: io.opentelemetry.aws-lambda-events-3.11 | ||
| target_versions: | ||
| library: | ||
| - com.amazonaws:aws-lambda-java-events:3.11.0 | ||
| - com.amazonaws:aws-lambda-java-core:1.0.0 | ||
| configurations: | ||
| - name: otel.instrumentation.aws-lambda.flush-timeout | ||
| description: Flush timeout in milliseconds. | ||
| type: int | ||
| default: 10000 | ||
| telemetry: | ||
| - when: default | ||
| spans: | ||
| - span_kind: CONSUMER | ||
| attributes: | ||
| - name: messaging.destination.name | ||
| type: STRING | ||
| - name: messaging.message.id | ||
| type: STRING | ||
| - name: messaging.operation | ||
| type: STRING | ||
| - name: messaging.system | ||
| type: STRING | ||
| - span_kind: SERVER | ||
| attributes: | ||
| - name: cloud.account.id | ||
| type: STRING | ||
| - name: cloud.resource_id | ||
| type: STRING | ||
| - name: faas.invocation_id | ||
| type: STRING | ||
| - name: faas.trigger | ||
| type: STRING | ||
| - name: http.request.method | ||
| type: STRING | ||
| - name: http.response.status_code | ||
| type: LONG | ||
| - name: url.full | ||
| type: STRING | ||
| - name: user_agent.original | ||
| type: STRING | ||
| - name: aws-sdk-1.11 | ||
| description: | | ||
| This instrumentation covers the AWS SDK 1.11+ client library, enabling messaging and client spans and metrics for calls to AWS services including DynamoDB, EC2, Kinesis, Lambda, RDS, S3, secrets manager, SNS/SQS and step functions. | ||
|
|
@@ -3964,6 +4008,16 @@ libraries: | |
| target_versions: | ||
| library: | ||
| - org.apache.kafka:kafka-clients:2.6.0 | ||
| configurations: | ||
| - name: otel.instrumentation.messaging.experimental.capture-headers | ||
| description: A comma-separated list of header names to capture as span attributes. | ||
| type: list | ||
| default: '' | ||
| - name: otel.instrumentation.messaging.experimental.receive-telemetry.enabled | ||
| description: | | ||
| Enables experimental receive telemetry, which will cause consumers to start a new trace, with only a span link connecting it to the producer trace. | ||
| type: boolean | ||
| default: false | ||
| - name: kafka-streams-0.11 | ||
| source_path: instrumentation/kafka/kafka-streams-0.11 | ||
| scope: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 10 additions & 3 deletions
13
instrumentation/aws-lambda/aws-lambda-events-2.2/metadata.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,16 @@ | ||
| description: > | ||
| Provides full instrumentation of the Lambda library, including standard and custom event types, | ||
| from `aws-lambda-java-events` 2.2+. | ||
| This version of the library instrumentation is deprecated, please use the aws-lambda-events-3.11 | ||
| library instrumentation instead. This instrumentation builds on top of the lightweight | ||
| `aws-lambda-core-1.0` instrumentation, expanding support to cover the Lambda library, including | ||
| standard and custom event types. | ||
| configurations: | ||
| - name: otel.instrumentation.aws-lambda.flush-timeout | ||
| type: int | ||
| default: 10000 | ||
| description: Flush timeout in milliseconds. | ||
|
|
||
| - name: otel.instrumentation.http.known-methods | ||
| description: > | ||
| Configures the instrumentation to recognize an alternative set of HTTP request methods. All | ||
| other methods will be treated as `_OTHER`. | ||
| type: list | ||
| default: "CONNECT,DELETE,GET,HEAD,OPTIONS,PATCH,POST,PUT,TRACE" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
instrumentation/aws-lambda/aws-lambda-events-3.11/metadata.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| description: > | ||
| This instrumentation builds on top of the lightweight `aws-lambda-core-1.0` instrumentation, | ||
| expanding support to cover the Lambda library, including standard and custom event types. | ||
| configurations: | ||
| - name: otel.instrumentation.aws-lambda.flush-timeout | ||
| type: int | ||
| default: 10000 | ||
| description: Flush timeout in milliseconds. | ||
|
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd replace
env propertywithenvironment variable