-
Notifications
You must be signed in to change notification settings - Fork 1k
Metadata for aws lambda events 3.11 #14514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
docs/instrumentation-list.yaml
Outdated
| type: STRING | ||
| - name: aws-lambda-events-3.11 | ||
| description: | | ||
| Provides full instrumentation of the Lambda library, including standard and custom event types, from `aws-lambda-java-events` 3.11+. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is copied form the old instrumentation which in turn copies from https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/aws-lambda/README.md Imo the meaning for full instrumentation is lost here without knowing that this instrumentation builds on top of aws-lambda-core-1.0 that provides lightweight instrumentation
c39eebd to
8142155
Compare
8142155 to
55b6534
Compare
docs/instrumentation-list.yaml
Outdated
| - name: aws-lambda-core-1.0 | ||
| description: | | ||
| Provides lightweight instrumentation of the Lambda core library, supporting all versions. It generates FaaS SERVER spans with the `faas.invocation_id` attribute. Use this package if you only use `RequestStreamHandler` or know you don't use any event classes from `aws-lambda-java-events`. This also includes when you are using `aws-serverless-java-container` to run e.g., a Spring Boot application on Lambda. | ||
| For custom wrappers when using library instrumentation, you can configure the `OTEL_INSTRUMENTATION_AWS_LAMBDA_HANDLER` env property to your lambda handler method in following format `package.ClassName::methodName` and use one of wrappers as your lambda `Handler`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd replace env property with environment variable
docs/instrumentation-list.yaml
Outdated
| - name: aws-lambda-events-2.2 | ||
| description: | | ||
| Provides full instrumentation of the Lambda library, including standard and custom event types, from `aws-lambda-java-events` 2.2+. | ||
| This version of the library instrumentation is deprecated, please use the aws-lambda-events-3.11 library instrumentation instead. This instrumentation builds on top of the lightweight `aws-lambda-core-1.0` instrumentation, expanding support to cover the Lambda library, including standard and custom event types. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd remove lightweight
…mentation into metadata-lambda-3
No description provided.