Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 44 additions & 1 deletion docs/instrumentation-list.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -945,7 +945,7 @@ libraries:
type: STRING
- name: aws-lambda-events-2.2
description: |
Provides full instrumentation of the Lambda library, including standard and custom event types, from `aws-lambda-java-events` 2.2+.
This version of the library instrumentation is deprecated, please use the aws-lambda-events-3.11 library instrumentation instead. Provides instrumentation of the Lambda library, including standard and custom event types, from `aws-lambda-java-events` 2.2+. Does not support SQSBatchResponse.
source_path: instrumentation/aws-lambda/aws-lambda-events-2.2
scope:
name: io.opentelemetry.aws-lambda-events-2.2
Expand All @@ -960,6 +960,11 @@ libraries:
description: Flush timeout in milliseconds.
type: int
default: 10000
- name: otel.instrumentation.http.known-methods
description: |
Configures the instrumentation to recognize an alternative set of HTTP request methods. All other methods will be treated as `_OTHER`.
type: list
default: CONNECT,DELETE,GET,HEAD,OPTIONS,PATCH,POST,PUT,TRACE
telemetry:
- when: default
spans:
Expand All @@ -984,13 +989,51 @@ libraries:
- name: user_agent.original
type: STRING
- name: aws-lambda-events-3.11
description: |
Provides full instrumentation of the Lambda library, including standard and custom event types, from `aws-lambda-java-events` 3.11+.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is copied form the old instrumentation which in turn copies from https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/aws-lambda/README.md Imo the meaning for full instrumentation is lost here without knowing that this instrumentation builds on top of aws-lambda-core-1.0 that provides lightweight instrumentation

source_path: instrumentation/aws-lambda/aws-lambda-events-3.11
scope:
name: io.opentelemetry.aws-lambda-events-3.11
target_versions:
library:
- com.amazonaws:aws-lambda-java-events:3.11.0
- com.amazonaws:aws-lambda-java-core:1.0.0
configurations:
- name: otel.instrumentation.aws-lambda.flush-timeout
description: Flush timeout in milliseconds.
type: int
default: 10000
telemetry:
- when: default
spans:
- span_kind: CONSUMER
attributes:
- name: messaging.destination.name
type: STRING
- name: messaging.message.id
type: STRING
- name: messaging.operation
type: STRING
- name: messaging.system
type: STRING
- span_kind: SERVER
attributes:
- name: cloud.account.id
type: STRING
- name: cloud.resource_id
type: STRING
- name: faas.invocation_id
type: STRING
- name: faas.trigger
type: STRING
- name: http.request.method
type: STRING
- name: http.response.status_code
type: LONG
- name: url.full
type: STRING
- name: user_agent.original
type: STRING
- name: aws-sdk-1.11
description: |
This instrumentation covers the AWS SDK 1.11+ client library, enabling messaging and client spans and metrics for calls to AWS services including DynamoDB, EC2, Kinesis, Lambda, RDS, S3, secrets manager, SNS/SQS and step functions.
Expand Down
1 change: 1 addition & 0 deletions instrumentation-docs/instrumentations.sh
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ readonly INSTRUMENTATIONS=(
"openai:openai-java-1.1:javaagent:test"
"aws-lambda:aws-lambda-core-1.0:javaagent:test"
"aws-lambda:aws-lambda-events-2.2:javaagent:test"
"aws-lambda:aws-lambda-events-3.11:library:test"
"cassandra:cassandra-3.0:javaagent:test"
"cassandra:cassandra-3.0:javaagent:testStableSemconv"
"cassandra:cassandra-4.0:javaagent:test"
Expand Down
13 changes: 10 additions & 3 deletions instrumentation/aws-lambda/aws-lambda-events-2.2/metadata.yaml
Original file line number Diff line number Diff line change
@@ -1,9 +1,16 @@
description: >
Provides full instrumentation of the Lambda library, including standard and custom event types,
from `aws-lambda-java-events` 2.2+.
This version of the library instrumentation is deprecated, please use the aws-lambda-events-3.11
library instrumentation instead. Provides instrumentation of the Lambda library, including
standard and custom event types, from `aws-lambda-java-events` 2.2+. Does not support
SQSBatchResponse.
configurations:
- name: otel.instrumentation.aws-lambda.flush-timeout
type: int
default: 10000
description: Flush timeout in milliseconds.

- name: otel.instrumentation.http.known-methods
description: >
Configures the instrumentation to recognize an alternative set of HTTP request methods. All
other methods will be treated as `_OTHER`.
type: list
default: "CONNECT,DELETE,GET,HEAD,OPTIONS,PATCH,POST,PUT,TRACE"
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,15 @@ dependencies {
testImplementation("uk.org.webcompere:system-stubs-jupiter")
}

tasks.withType<Test>().configureEach {
// required on jdk17
jvmArgs("--add-opens=java.base/java.lang=ALL-UNNAMED")
jvmArgs("--add-opens=java.base/java.util=ALL-UNNAMED")
jvmArgs("-XX:+IgnoreUnrecognizedVMOptions")
tasks {
withType<Test>().configureEach {
// required on jdk17
jvmArgs("--add-opens=java.base/java.lang=ALL-UNNAMED")
jvmArgs("--add-opens=java.base/java.util=ALL-UNNAMED")
jvmArgs("-XX:+IgnoreUnrecognizedVMOptions")
}

test {
systemProperty("collectMetadata", findProperty("collectMetadata")?.toString() ?: "false")
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
description: >
Provides full instrumentation of the Lambda library, including standard and custom event types,
from `aws-lambda-java-events` 3.11+.
configurations:
- name: otel.instrumentation.aws-lambda.flush-timeout
type: int
default: 10000
description: Flush timeout in milliseconds.

Loading