-
Notifications
You must be signed in to change notification settings - Fork 1k
Build and use a local snapshot for benchmark tests #14729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The main issue with the current approach is that it uses |
@laurit ah yea, looks like we could grab it from https://central.sonatype.com/artifact/io.opentelemetry.javaagent/opentelemetry-javaagent which would probably save a lot of time on this gradle task. Do you happen to have a preference on whether we pull it or build it? Edit: actually, still trying to find the actual snapshot |
See https://central.sonatype.com/repository/maven-snapshots/io/opentelemetry/javaagent/opentelemetry-javaagent/2.21.0-SNAPSHOT/maven-metadata.xml Note the
not really |
Yea I still haven't been able to figure out the actual path |
one possible advantage to using local build is that we could theoretically run the benchmark against PR branches, or against each merge to main... a little more flexible |
Co-authored-by: Lauri Tulmin <[email protected]>
Fixes #14701
Finding/downloading snapshots from sonatype has been unreliable, we've tried addressing intermittent network issues with retries (#14366), but now we are seeing 404s. @trask had suggested we could just assemble the snapshot ourself, so that's what I did here.
I tested this on my fork here