Skip to content

Conversation

@jaydeluca
Copy link
Member

Fixes #14701

Finding/downloading snapshots from sonatype has been unreliable, we've tried addressing intermittent network issues with retries (#14366), but now we are seeing 404s. @trask had suggested we could just assemble the snapshot ourself, so that's what I did here.

I tested this on my fork here

@jaydeluca jaydeluca requested a review from a team as a code owner September 20, 2025 13:12
@laurit
Copy link
Contributor

laurit commented Sep 23, 2025

The main issue with the current approach is that it uses oss.sonatype.org. We don't publish snapshots there any more. If it used https://central.sonatype.com/repository/maven-snapshots/ it would probably work better. That being said assembling the jar is also fine.

@jaydeluca
Copy link
Member Author

jaydeluca commented Sep 23, 2025

The main issue with the current approach is that it uses oss.sonatype.org. We don't publish snapshots there any more. If it used central.sonatype.com/repository/maven-snapshots it would probably work better. That being said assembling the jar is also fine.

@laurit ah yea, looks like we could grab it from https://central.sonatype.com/artifact/io.opentelemetry.javaagent/opentelemetry-javaagent which would probably save a lot of time on this gradle task. Do you happen to have a preference on whether we pull it or build it?

Edit: actually, still trying to find the actual snapshot

@laurit
Copy link
Contributor

laurit commented Sep 24, 2025

Edit: actually, still trying to find the actual snapshot

See https://central.sonatype.com/repository/maven-snapshots/io/opentelemetry/javaagent/opentelemetry-javaagent/2.21.0-SNAPSHOT/maven-metadata.xml Note the maven-snapshots in the url. Repository browsing is disabled so idk what the actual agent file name is.

Do you happen to have a preference on whether we pull it or build it?

not really

@jaydeluca
Copy link
Member Author

See https://central.sonatype.com/repository/maven-snapshots/io/opentelemetry/javaagent/opentelemetry-javaagent/2.21.0-SNAPSHOT/maven-metadata.xml Note the maven-snapshots in the url. Repository browsing is disabled so idk what the actual agent file name is.

Yea I still haven't been able to figure out the actual path

@trask
Copy link
Member

trask commented Sep 24, 2025

Yea I still haven't been able to figure out the actual path

https://central.sonatype.com/repository/maven-snapshots/io/opentelemetry/javaagent/opentelemetry-javaagent/2.21.0-SNAPSHOT/opentelemetry-javaagent-2.21.0-20250924.172006-52.jar

one possible advantage to using local build is that we could theoretically run the benchmark against PR branches, or against each merge to main... a little more flexible

@jaydeluca jaydeluca mentioned this pull request Sep 25, 2025
@trask trask merged commit b58774b into open-telemetry:main Sep 26, 2025
89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Workflow failed: Overhead benchmark (daily) (#1272)

3 participants