Fix flaky openai test #15185
Merged
Fix flaky openai test #15185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeitlinger
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://develocity.opentelemetry.io/s/s3khsy5f64yei/tests/task/:instrumentation:openai:openai-java-1.1:javaagent:test/details/io.opentelemetry.javaagent.instrumentation.openai.v1_1.ChatTest/streamConnectionError()?expanded-stacktrace=WyIyIl0&top-execution=1
It seems that this test fails only on openj9. I have a suspicion that openj9 gc is smart and figures out that some objects like the openai client have become unreachable before the test ends. Openai wraps okhttp in
PhantomReachableClosingHttpClientwhen this object becomes unreachable it will trigger the shutdown of the okhttp client. My guess is that okhttp client gets shut down before the test completes. Hopefully shutting down the openai client at the end of the test ensures that the openai client and the objects it uses won't get shut down too early.