Skip to content

Fix flaky openai test #15185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2025
+9 −0
Merged

Fix flaky openai test #15185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .../testing/src/main/java/io/opentelemetry/instrumentation/openai/v1_1/AbstractChatTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@
import io.opentelemetry.api.trace.SpanContext;
import io.opentelemetry.context.Context;
import io.opentelemetry.instrumentation.openai.TestHelper;
import io.opentelemetry.instrumentation.testing.internal.AutoCleanupExtension;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
Expand All @@ -73,15 +74,19 @@
import java.util.concurrent.CompletionException;
import java.util.stream.Collectors;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.RegisterExtension;

public abstract class AbstractChatTest extends AbstractOpenAiTest {

protected static final AttributeKey<String> EVENT_NAME = AttributeKey.stringKey("event.name");

protected static final String TEST_CHAT_MODEL = "gpt-4o-mini";
protected static final String TEST_CHAT_RESPONSE_MODEL = "gpt-4o-mini-2024-07-18";
protected static final String TEST_CHAT_INPUT =
"Answer in up to 3 words: Which ocean contains Bouvet Island?";

@RegisterExtension static final AutoCleanupExtension cleanup = AutoCleanupExtension.create();

protected final ChatCompletion doCompletions(ChatCompletionCreateParams params) {
return doCompletions(params, getClient(), getClientAsync());
}
Expand Down Expand Up @@ -878,6 +883,8 @@ void connectionError() {
.apiKey("testing")
.maxRetries(0)
.build());
cleanup.deferCleanup(client::close);
cleanup.deferCleanup(clientAsync::close);

ChatCompletionCreateParams params =
ChatCompletionCreateParams.builder()
Expand Down Expand Up @@ -1583,6 +1590,8 @@ void streamConnectionError() {
.apiKey("testing")
.maxRetries(0)
.build());
cleanup.deferCleanup(client::close);
cleanup.deferCleanup(clientAsync::close);

ChatCompletionCreateParams params =
ChatCompletionCreateParams.builder()
Expand Down
Loading