fix graal native image #15306
fix graal native image #15306
Conversation
github-actions
bot
added
the
test native
| private static MethodHandle findGetHeadersMethod(MethodType methodType) { | ||
| try { | ||
| return MethodHandles.lookup().findVirtual(HttpHeaders.class, "getOrDefault", methodType); | ||
| return MethodHandles.lookup().findVirtual(HttpHeaders.class, "get", methodType); |
There was a problem hiding this comment.
would be interesting to know why getOrDefault failed
There was a problem hiding this comment.
Yes, but I don't have an answer
| // up to spring web 7.0 | ||
| methodHandle = | ||
| findGetHeadersMethod(MethodType.methodType(Object.class, Object.class, Object.class)); | ||
| methodHandle = findGetHeadersMethod(MethodType.methodType(List.class, Object.class)); |
There was a problem hiding this comment.
should be Object.class, Object.class
There was a problem hiding this comment.
|
I created #15311 that uses a slightly different approach just to test out whether it would work. Noticed that for webflux instrumentation the header getter logic is duplicated for client and server instrumentation, fixed that too. The approach taken in this PR is fine too and I might even prefer it. Though first all tests would need to pass. |
great - I'm also trying to fix this PR so that we can choose.
|
2 participants
We broke native image and didn't realize it because