Skip to content

fix graal native image #15306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
+64 −51
Open

fix graal native image #15306

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
eae2f25
debug native image fail
zeitlinger Nov 14, 2025
894b326
fix
zeitlinger Nov 14, 2025
d79c790
fix
zeitlinger Nov 14, 2025
1f986c1
cleanup
zeitlinger Nov 14, 2025
1599e23
fix
zeitlinger Nov 14, 2025
5490492
fix
zeitlinger Nov 14, 2025
ccf3bcf
fix
zeitlinger Nov 14, 2025
925e44c
fix
zeitlinger Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions .../java/io/opentelemetry/instrumentation/spring/web/v3_1/SpringWebHttpAttributesGetter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,18 +61,17 @@ enum SpringWebHttpAttributesGetter

// since spring web 7.0
MethodHandle methodHandle =
findGetHeadersMethod(MethodType.methodType(List.class, String.class, List.class));
findGetHeadersMethod(MethodType.methodType(List.class, String.class));
if (methodHandle == null) {
// up to spring web 7.0
methodHandle =
findGetHeadersMethod(MethodType.methodType(Object.class, Object.class, Object.class));
methodHandle = findGetHeadersMethod(MethodType.methodType(List.class, Object.class));
Copy link
Contributor

@laurit laurit Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be Object.class, Object.class

Copy link
Member Author

@zeitlinger zeitlinger Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so: https://github.com/spring-projects/spring-framework/blob/6.2.x/spring-web/src/main/java/org/springframework/http/HttpHeaders.java#L1822-L1824

}
GET_HEADERS = methodHandle;
}

private static MethodHandle findGetHeadersMethod(MethodType methodType) {
try {
return MethodHandles.lookup().findVirtual(HttpHeaders.class, "getOrDefault", methodType);
return MethodHandles.lookup().findVirtual(HttpHeaders.class, "get", methodType);
Copy link
Contributor

@laurit laurit Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be interesting to know why getOrDefault failed

Copy link
Member Author

@zeitlinger zeitlinger Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but I don't have an answer

} catch (Throwable t) {
return null;
}
Expand All @@ -98,7 +97,11 @@ public List<String> getHttpRequestHeader(HttpRequest httpRequest, String name) {
private static List<String> getHeader(HttpHeaders headers, String name) {
if (GET_HEADERS != null) {
try {
return (List<String>) GET_HEADERS.invoke(headers, name, emptyList());
List<String> result = (List<String>) GET_HEADERS.invoke(headers, name);
if (result == null) {
return emptyList();
}
return result;
} catch (Throwable t) {
// ignore
}
Expand Down
13 changes: 8 additions & 5 deletions ...ibrary/src/main/java/io/opentelemetry/instrumentation/spring/webflux/v5_3/HeaderUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,18 +20,17 @@ class HeaderUtil {
static {
// since spring web 7.0
MethodHandle methodHandle =
findGetHeadersMethod(MethodType.methodType(List.class, String.class, List.class));
findGetHeadersMethod(MethodType.methodType(List.class, String.class));
if (methodHandle == null) {
// up to spring web 7.0
methodHandle =
findGetHeadersMethod(MethodType.methodType(Object.class, Object.class, Object.class));
methodHandle = findGetHeadersMethod(MethodType.methodType(List.class, Object.class));
}
GET_HEADERS = methodHandle;
}

private static MethodHandle findGetHeadersMethod(MethodType methodType) {
try {
return MethodHandles.lookup().findVirtual(HttpHeaders.class, "getOrDefault", methodType);
return MethodHandles.lookup().findVirtual(HttpHeaders.class, "get", methodType);
} catch (Throwable t) {
return null;
}
Expand All @@ -41,7 +40,11 @@ private static MethodHandle findGetHeadersMethod(MethodType methodType) {
static List<String> getHeader(HttpHeaders headers, String name) {
if (GET_HEADERS != null) {
try {
return (List<String>) GET_HEADERS.invoke(headers, name, emptyList());
List<String> result = (List<String>) GET_HEADERS.invoke(headers, name);
if (result == null) {
return emptyList();
}
return result;
} catch (Throwable t) {
// ignore
}
Expand Down
13 changes: 8 additions & 5 deletions ...telemetry/instrumentation/spring/webflux/v5_3/internal/WebClientHttpAttributesGetter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,18 +30,17 @@ public enum WebClientHttpAttributesGetter
static {
// since webflux 7.0
MethodHandle methodHandle =
findGetHeadersMethod(MethodType.methodType(List.class, String.class, List.class));
findGetHeadersMethod(MethodType.methodType(List.class, String.class));
if (methodHandle == null) {
// up to webflux 7.0
methodHandle =
findGetHeadersMethod(MethodType.methodType(Object.class, Object.class, Object.class));
methodHandle = findGetHeadersMethod(MethodType.methodType(List.class, Object.class));
}
GET_HEADERS = methodHandle;
}

private static MethodHandle findGetHeadersMethod(MethodType methodType) {
try {
return MethodHandles.lookup().findVirtual(HttpHeaders.class, "getOrDefault", methodType);
return MethodHandles.lookup().findVirtual(HttpHeaders.class, "get", methodType);
} catch (Throwable t) {
return null;
}
Expand All @@ -62,7 +61,11 @@ public String getHttpRequestMethod(ClientRequest request) {
public List<String> getHttpRequestHeader(ClientRequest request, String name) {
if (GET_HEADERS != null) {
try {
return (List<String>) GET_HEADERS.invoke(request.headers(), name, emptyList());
List<String> result = (List<String>) GET_HEADERS.invoke(request, name);
if (result == null) {
return emptyList();
}
return result;
} catch (Throwable t) {
// ignore
}
Expand Down
Loading