fix(deps): update errorproneversion to v2.46.0

[renovate]

This PR contains the following updates:

Package	Change	Age	Confidence
com.google.errorprone:error_prone_test_helpers (source)	2.45.0 → 2.46.0
com.google.errorprone:error_prone_core (source)	2.45.0 → 2.46.0
com.google.errorprone:error_prone_annotations (source)	2.45.0 → 2.46.0

---

Release Notes

google/error-prone (com.google.errorprone:error_prone_test_helpers)

v2.46.0: Error Prone 2.46.0

Changes:

• The javac flag -XDaddTypeAnnotationsToSymbol=true is now required for Error Prone invocations on JDK 21, to enable the javac fix for JDK-8225377: type annotations are not visible to javac plugins across compilation boundaries. See #​5426 for details.
• Remove deprecated value attribute from @IncompatibleModifiers and @RequiredModifiers (#​2122)
• Error Prone API changes to encapsulate references to internal javac APIs for end position handling (EndPosTable, DiagnosticPosition) (5440bb4, 06c2905, f3915ec)

New checks:

• DuplicateAssertion: detect duplicated assertion lines where the argument to assertThat is pure
• IfChainToSwitch: suggest converting chains of if-statements into arrow switches
• ScannerUseDelimiter: discourage Scanner.useDelimiter("\\A")
• AddNullMarkedToClass: refactoring to add @NullMarked annotation to top level classes

---

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

---

• If you want to rebase/retry this PR, check this box

---

This PR was generated by Mend Renovate. View the repository job log.

[breedx-splk]

Breaking changes from a minor release of errorprone.....what's this world coming to. 🤯

* What went wrong:
Execution failed for task ':custom-checks:compileJava'.
> -XDaddTypeAnnotationsToSymbol=true is required by Error Prone on JDK 21

[renovate]

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

[breedx-splk]

I think I did the right thing, but keep me honest. 🙏🏻

[jkwatson]

it'd be interesting to see how much bytecode bloat this introduces. Not something blocking; just for educational purposes.

[breedx-splk]

yeah I wouldn't expect it to be too much at all.

[laurit]

Reading https://bugs.openjdk.org/browse/JDK-8225377 it looks to me like it won't affect the generated bytecode.