Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ val testLatestDeps = gradle.startParameter.projectProperties["testLatestDeps"] =
tasks {
withType<JavaCompile>().configureEach {
with(options) {
compilerArgs.add("-XDaddTypeAnnotationsToSymbol=true")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it'd be interesting to see how much bytecode bloat this introduces. Not something blocking; just for educational purposes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I wouldn't expect it to be too much at all.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading https://bugs.openjdk.org/browse/JDK-8225377 it looks to me like it won't affect the generated bytecode.

errorprone {
if (disableErrorProne) {
logger.warn("Errorprone has been disabled. Build may not result in a valid PR build.")
Expand Down Expand Up @@ -123,6 +124,7 @@ tasks {
disable("NonFinalStaticField")

// Requires adding compile dependency to JSpecify
disable("AddNullMarkedToClass")
disable("AddNullMarkedToPackageInfo")

if (testLatestDeps) {
Expand Down
2 changes: 1 addition & 1 deletion dependencyManagement/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ val DEPENDENCY_BOMS = listOf(

val autoServiceVersion = "1.1.1"
val autoValueVersion = "1.11.1"
val errorProneVersion = "2.45.0"
val errorProneVersion = "2.46.0"
val byteBuddyVersion = "1.18.3"
val asmVersion = "9.9.1"
val jmhVersion = "1.37"
Expand Down