Skip to content

Disable equals verifier ranges#7415

Closed
breedx-splk wants to merge 4 commits intoopen-telemetry:mainfrom
breedx-splk:disable_equals_verifier_ranges
Closed

Disable equals verifier ranges#7415
breedx-splk wants to merge 4 commits intoopen-telemetry:mainfrom
breedx-splk:disable_equals_verifier_ranges

Conversation

@breedx-splk
Copy link
Contributor

Supersedes #7319.

We only have a few places where we use the EqualsVerifier, so can we just prevent those tests from running with older JDKs? Is this a reasonable approach/compromise?

@breedx-splk breedx-splk requested a review from a team as a code owner June 10, 2025 22:37
@codecov
Copy link

codecov bot commented Jun 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.75%. Comparing base (5bda810) to head (f245fac).
Report is 62 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7415      +/-   ##
============================================
- Coverage     89.90%   89.75%   -0.16%     
- Complexity     6893     6980      +87     
============================================
  Files           785      797      +12     
  Lines         20791    21165     +374     
  Branches       2024     2057      +33     
============================================
+ Hits          18692    18996     +304     
- Misses         1460     1505      +45     
- Partials        639      664      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@breedx-splk
Copy link
Contributor Author

Hrmph. It looks to have passed on 8 but is failing on 11, seemingly due to the module system.
image
Maybe I don't know how to work around this after all. 😭

@breedx-splk
Copy link
Contributor Author

The migration guide straight-up says not to upgrade. Ho hum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant