Disable equals verifier ranges#7415
Closed
breedx-splk wants to merge 4 commits intoopen-telemetry:mainfrom
Closed
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7415 +/- ##
============================================
- Coverage 89.90% 89.75% -0.16%
- Complexity 6893 6980 +87
============================================
Files 785 797 +12
Lines 20791 21165 +374
Branches 2024 2057 +33
============================================
+ Hits 18692 18996 +304
- Misses 1460 1505 +45
- Partials 639 664 +25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
Contributor
Author
|
The migration guide straight-up says not to upgrade. Ho hum. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Supersedes #7319.
We only have a few places where we use the
EqualsVerifier, so can we just prevent those tests from running with older JDKs? Is this a reasonable approach/compromise?