Skip to content

Disable equals verifier ranges #7415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
breedx-splk wants to merge 4 commits into from
Closed

Disable equals verifier ranges #7415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ea09a93
fix(deps): update dependency nl.jqno.equalsverifier:equalsverifier to v4
renovate[bot] May 6, 2025
0832f29
limit equalsverifier tests to java17+
breedx-splk Jun 10, 2025
4fedb72
fix annotation
breedx-splk Jun 10, 2025
f245fac
spotless
breedx-splk Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions api/all/src/test/java/io/opentelemetry/api/common/AttributeKeyTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,12 @@
import io.opentelemetry.api.internal.InternalAttributeKeyImpl;
import nl.jqno.equalsverifier.EqualsVerifier;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.condition.EnabledForJreRange;

class AttributeKeyTest {

@Test
@EnabledForJreRange(minVersion = 17, disabledReason = "EqualsVerifier requires Java 17+")
void equalsVerifier() {
EqualsVerifier.forClass(InternalAttributeKeyImpl.class)
.withIgnoredFields("keyUtf8")
Expand Down
2 changes: 1 addition & 1 deletion dependencyManagement/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ val DEPENDENCIES = listOf(
"io.opentracing:opentracing-api:0.33.0",
"io.opentracing:opentracing-noop:0.33.0",
"junit:junit:4.13.2",
"nl.jqno.equalsverifier:equalsverifier:3.19.4",
"nl.jqno.equalsverifier:equalsverifier:4.0",
"org.awaitility:awaitility:4.3.0",
"org.bouncycastle:bcpkix-jdk15on:1.70",
"org.codehaus.mojo:animal-sniffer-annotations:1.24",
Expand Down
2 changes: 2 additions & 0 deletions ...p/common/src/test/java/io/opentelemetry/exporter/internal/otlp/AttributeKeyValueTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,12 @@
import nl.jqno.equalsverifier.EqualsVerifier;
import org.assertj.core.api.Assertions;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.condition.EnabledForJreRange;

class AttributeKeyValueTest {

@Test
@EnabledForJreRange(minVersion = 17, disabledReason = "EqualsVerifier requires Java 17+")
void equalsVerifier() {
EqualsVerifier.forClass(AttributeKeyValue.class).verify();
}
Expand Down
2 changes: 2 additions & 0 deletions sdk/trace/src/test/java/io/opentelemetry/sdk/trace/samplers/ParentBasedSamplerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
import java.util.Collections;
import nl.jqno.equalsverifier.EqualsVerifier;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.condition.EnabledForJreRange;

class ParentBasedSamplerTest {
private static final String SPAN_NAME = "MySpanName";
Expand Down Expand Up @@ -409,6 +410,7 @@ void getDescription() {
}

@Test
@EnabledForJreRange(minVersion = 17, disabledReason = "EqualsVerifier requires Java 17+")
void equals() {
EqualsVerifier.forClass(ParentBasedSampler.class)
.withNonnullFields(
Expand Down
Loading