Skip to content

Conversation

@seemk
Copy link
Contributor

@seemk seemk commented Jul 18, 2024

Which problem is this PR solving?

Drop SQS processing spans in favor of span links as per latest specification.

Fixes #707

Short description of the changes

Create a span link for each incoming message that has a propagation context.

@seemk seemk changed the title feat(aws-sdk): use span links instead of processing spans feat(aws-sdk): SQS receive: use span links instead of processing spans Jul 18, 2024
@codecov
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.53%. Comparing base (8b09de9) to head (8c2c582).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2345      +/-   ##
==========================================
+ Coverage   89.52%   89.53%   +0.01%     
==========================================
  Files         192      192              
  Lines        9677     9679       +2     
  Branches     2009     2009              
==========================================
+ Hits         8663     8666       +3     
+ Misses       1014     1013       -1     
Files with missing lines Coverage Δ
packages/instrumentation-aws-sdk/src/semconv.ts 100.00% <100.00%> (ø)
...ckages/instrumentation-aws-sdk/src/services/sqs.ts 100.00% <100.00%> (+1.51%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot requested a review from blumamir September 10, 2024 10:38
@seemk seemk requested a review from a team as a code owner September 25, 2024 04:14
@seemk
Copy link
Contributor Author

seemk commented Nov 6, 2024

@jj22ee

@pichlermarc
Copy link
Member

cc @jj22ee @trivikr (component owner)

@seemk
Copy link
Contributor Author

seemk commented Jun 30, 2025

@jj22ee @trivikr up to date

@dyladan
Copy link
Member

dyladan commented Jul 9, 2025

@seemk the conflicts are because of a package naming restructure of the directory. Sorry for the excess work.

@jj22ee can you please take a look at this? This is now the specified behavior and I believe we should accept this change.

@seemk
Copy link
Contributor Author

seemk commented Jul 24, 2025

@seemk the conflicts are because of a package naming restructure of the directory. Sorry for the excess work.

@jj22ee can you please take a look at this? This is now the specified behavior and I believe we should accept this change.

@dyladan Updated

@jj22ee

@dyladan
Copy link
Member

dyladan commented Aug 6, 2025

@jj22ee please give this a review. It is implementing spec behavior

@trentm
Copy link
Contributor

trentm commented Aug 26, 2025

^^ I merged with main (fixing a couple easy conflicts) so we can get the tests running here again.
I'd love to get this in.
I'll also add a ! to the title to mark this as a breaking change.

@trentm trentm changed the title feat(aws-sdk): SQS receive: use span links instead of processing spans feat(aws-sdk)!: SQS receive: use span links instead of processing spans Aug 26, 2025
spanName = `${queueName} receive`;
spanAttributes[SEMATTRS_MESSAGING_OPERATION] =
MESSAGINGOPERATIONVALUES_RECEIVE;
spanAttributes[ATTR_MESSAGING_OPERATION_TYPE] = 'receive';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: There are enum value exports from the unstable semantic-conventions exports that could be used for 'receive' here (and aws_sqs above):

8674:export const MESSAGING_OPERATION_TYPE_VALUE_CREATE = "create" as const;
8685:export const MESSAGING_OPERATION_TYPE_VALUE_DELIVER = "deliver" as const;
8694:export const MESSAGING_OPERATION_TYPE_VALUE_PROCESS = "process" as const;
8705:export const MESSAGING_OPERATION_TYPE_VALUE_PUBLISH = "publish" as const;
8714:export const MESSAGING_OPERATION_TYPE_VALUE_RECEIVE = "receive" as const;
8723:export const MESSAGING_OPERATION_TYPE_VALUE_SEND = "send" as const;
8732:export const MESSAGING_OPERATION_TYPE_VALUE_SETTLE = "settle" as const;

However, this is very minor and could be done in a follow-up PR.

@trentm trentm requested a review from jj22ee August 26, 2025 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Discussion(instrumentation-aws-sdk): SQS receive according to semantic conventions

7 participants