feat(aws-sdk)!: SQS receive: use span links instead of processing spans #2345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seemk
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2345 +/- ##
==========================================
+ Coverage 89.52% 89.53% +0.01%
==========================================
Files 192 192
Lines 9677 9679 +2
Branches 2009 2009
==========================================
+ Hits 8663 8666 +3
+ Misses 1014 1013 -1
🚀 New features to boost your workflow:
|
Contributor
Author
Member
Contributor
Author
Member
Contributor
Author
Member
|
@jj22ee please give this a review. It is implementing spec behavior |
Contributor
|
^^ I merged with main (fixing a couple easy conflicts) so we can get the tests running here again. |
trentm
changed the title
This just re-orders and adds the block comments from the semantic-conventions package.
trentm
approved these changes
Aug 26, 2025
| spanName = `${queueName} receive`; | ||
| spanAttributes[SEMATTRS_MESSAGING_OPERATION] = | ||
| MESSAGINGOPERATIONVALUES_RECEIVE; | ||
| spanAttributes[ATTR_MESSAGING_OPERATION_TYPE] = 'receive'; |
Contributor
There was a problem hiding this comment.
nit: There are enum value exports from the unstable semantic-conventions exports that could be used for 'receive' here (and aws_sqs above):
8674:export const MESSAGING_OPERATION_TYPE_VALUE_CREATE = "create" as const;
8685:export const MESSAGING_OPERATION_TYPE_VALUE_DELIVER = "deliver" as const;
8694:export const MESSAGING_OPERATION_TYPE_VALUE_PROCESS = "process" as const;
8705:export const MESSAGING_OPERATION_TYPE_VALUE_PUBLISH = "publish" as const;
8714:export const MESSAGING_OPERATION_TYPE_VALUE_RECEIVE = "receive" as const;
8723:export const MESSAGING_OPERATION_TYPE_VALUE_SEND = "send" as const;
8732:export const MESSAGING_OPERATION_TYPE_VALUE_SETTLE = "settle" as const;
However, this is very minor and could be done in a follow-up PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Drop SQS processing spans in favor of span links as per latest specification.
Fixes #707
Short description of the changes
Create a span link for each incoming message that has a propagation context.