Skip to content

Conversation

@danherd
Copy link
Contributor

@danherd danherd commented Apr 2, 2025

Which problem is this PR solving?

With open-telemetry/opentelemetry-js#5443 we've introduced new utility functions for getting getting environment variables in an OTel Spec compliant manner, and we've migrated from using the old getEnv() utility function (#2708).

However, to provide an easier upgrade-path, for users of getEnv() we've also introduced a utility function to get a log level from a string, so the mapping we now do is now obsolete and we should align it with the core repo.

Refs #2774

Short description of the changes

Removed unnecessary utility function, map and tests. Replaced with new core utility functions.

@danherd danherd requested a review from a team as a code owner April 2, 2025 16:02
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 2, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@danherd danherd changed the title refactor(auto-instrumentations-node): use env var utility functions t… refactor(auto-instrumentations-node): use env var utility functions to setup diagnostics logging Apr 2, 2025
@codecov
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.50%. Comparing base (d2c1be4) to head (6f148e9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2778      +/-   ##
==========================================
+ Coverage   89.45%   89.50%   +0.05%     
==========================================
  Files         174      174              
  Lines        8324     8318       -6     
  Branches     1593     1591       -2     
==========================================
- Hits         7446     7445       -1     
+ Misses        878      873       -5     
Files with missing lines Coverage Δ
...tapackages/auto-instrumentations-node/src/utils.ts 98.23% <100.00%> (-0.09%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@david-luna david-luna merged commit e37d983 into open-telemetry:main Apr 8, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants