Skip to content

fix(instrumentation-kafkajs): add missing delcare keyword for metric instruments #2805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pichlermarc merged 2 commits into from
Apr 29, 2025
Merged

fix(instrumentation-kafkajs): add missing delcare keyword for metric instruments #2805

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc1d170
fix(instrumentation-kafkajs): add missing delcare keyword for metric …
pichlermarc Apr 29, 2025
f3fad29
Merge branch 'main' into fix/kafkajs-metrics
pichlermarc Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/node/instrumentation-kafkajs/src/instrumentation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,10 +163,10 @@ const HISTOGRAM_BUCKET_BOUNDARIES = [
0.005, 0.01, 0.025, 0.05, 0.075, 0.1, 0.25, 0.5, 0.75, 1, 2.5, 5, 7.5, 10,
];
export class KafkaJsInstrumentation extends InstrumentationBase<KafkaJsInstrumentationConfig> {
private _clientDuration!: Histogram<ClientDurationAttributes>;
private _sentMessages!: Counter<SentMessagesAttributes>;
private _consumedMessages!: Counter<ConsumedMessagesAttributes>;
private _processDuration!: Histogram<MessageProcessDurationAttributes>;
private declare _clientDuration: Histogram<ClientDurationAttributes>;
private declare _sentMessages: Counter<SentMessagesAttributes>;
private declare _consumedMessages: Counter<ConsumedMessagesAttributes>;
private declare _processDuration: Histogram<MessageProcessDurationAttributes>;

constructor(config: KafkaJsInstrumentationConfig = {}) {
super(PACKAGE_NAME, PACKAGE_VERSION, config);
Expand Down