-
Notifications
You must be signed in to change notification settings - Fork 596
chore(instrumentation-amqp): bump @types/amqplib and remove unnecessary casts #2960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(instrumentation-amqp): bump @types/amqplib and remove unnecessary casts #2960
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2960 +/- ##
=======================================
Coverage 89.53% 89.53%
=======================================
Files 192 192
Lines 9679 9679
Branches 2009 2009
=======================================
Hits 8666 8666
Misses 1013 1013
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @blumamir could you have a look as well?
a7454cd
to
f3cee2a
Compare
@blumamir ping :) |
f3cee2a
to
bf88c68
Compare
bf88c68
to
2d4df7b
Compare
CI is failing for because of missing assets. I'm going to update the branch to do another pass to the CI @lucas-gregoire if you want to make any other change just pull this last commit to avoid conflicts |
All green now :) @blumamir could you have a look? |
Which problem is this PR solving?
Short description of the changes
as any
casts that were required due to limitations in the previous amqplib types version.InstrumentationConsumeMessage
type to more accurately represent aConsumeMessage
along with its associated span.InstrumentationConnection
to avoidas any
cast