Skip to content

Conversation

lucas-gregoire
Copy link
Contributor

@lucas-gregoire lucas-gregoire commented Jul 27, 2025

Which problem is this PR solving?

  • Updates amqplib types to the latest released version, addressing type inconsistencies and improving type safety.

Short description of the changes

  • Removed unnecessary as any casts that were required due to limitations in the previous amqplib types version.
  • Introduced a new InstrumentationConsumeMessage type to more accurately represent a ConsumeMessage along with its associated span.
  • Introduced a new InstrumentationConnection to avoid as any cast
  • No behavior changes: this PR only involves typing improvements and does not alter the runtime behavior of the code.

@lucas-gregoire lucas-gregoire requested a review from a team as a code owner July 27, 2025 20:43
Copy link

linux-foundation-easycla bot commented Jul 27, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: lucas-gregoire / name: Lucas Grégoire (2d4df7b, 2e4d832)
  • ✅ login: pichlermarc / name: Marc Pichler (ee32d54)
  • ✅ login: david-luna / name: David Luna (516007b)

Copy link

codecov bot commented Jul 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.53%. Comparing base (bd9e782) to head (ee32d54).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2960   +/-   ##
=======================================
  Coverage   89.53%   89.53%           
=======================================
  Files         192      192           
  Lines        9679     9679           
  Branches     2009     2009           
=======================================
  Hits         8666     8666           
  Misses       1013     1013           
Files with missing lines Coverage Δ
packages/instrumentation-amqplib/src/amqplib.ts 90.53% <100.00%> (ø)
packages/instrumentation-amqplib/src/utils.ts 92.64% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@david-luna david-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @blumamir could you have a look as well?

@lucas-gregoire lucas-gregoire force-pushed the chore/bump-amqp-types branch from a7454cd to f3cee2a Compare August 3, 2025 13:59
@dyladan
Copy link
Member

dyladan commented Aug 6, 2025

@blumamir ping :)

@lucas-gregoire lucas-gregoire force-pushed the chore/bump-amqp-types branch from f3cee2a to bf88c68 Compare August 7, 2025 09:40
@lucas-gregoire lucas-gregoire force-pushed the chore/bump-amqp-types branch from bf88c68 to 2d4df7b Compare August 9, 2025 11:02
@david-luna
Copy link
Contributor

david-luna commented Aug 19, 2025

CI is failing for because of missing assets. I'm going to update the branch to do another pass to the CI

@lucas-gregoire if you want to make any other change just pull this last commit to avoid conflicts

@david-luna
Copy link
Contributor

All green now :)

@blumamir could you have a look?

@pichlermarc pichlermarc enabled auto-merge (squash) August 27, 2025 16:55
@pichlermarc pichlermarc merged commit 1d263e5 into open-telemetry:main Aug 27, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants