Skip to content

Conversation

pichlermarc
Copy link
Member

Which problem is this PR solving?

glob includes types in its latest version, also glob is not used in @opentelemetry/instrumentation-openai. The old @types/glob package breaks the package lock sync PR as its types are outdated: see #2989

@pichlermarc pichlermarc requested a review from a team as a code owner August 29, 2025 12:53
@github-actions github-actions bot requested review from seemk and trentm August 29, 2025 12:53
@pichlermarc pichlermarc changed the title deps(instrumentation-openai): remove unused dependency @types/glob chore(instrumentation-openai): remove unused dev dependency @types/glob Aug 29, 2025
Copy link

codecov bot commented Aug 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.55%. Comparing base (0c07a86) to head (303df47).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3004   +/-   ##
=======================================
  Coverage   89.55%   89.55%           
=======================================
  Files         193      193           
  Lines        9698     9698           
  Branches     2011     2011           
=======================================
  Hits         8685     8685           
  Misses       1013     1013           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pichlermarc pichlermarc merged commit 35c7754 into open-telemetry:main Sep 2, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants