refactor(otlp-exporter-base): use getStringFromEnv instead of process.env
#5594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the code to user the helper utilities to retrieve environment variable values fixes open-telemetry#5561 Signed-off-by: Weyert de Boer <[email protected]>
Signed-off-by: Weyert de Boer <[email protected]>
Signed-off-by: Weyert de Boer <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5594 +/- ##
=======================================
Coverage 95.06% 95.06%
=======================================
Files 307 307
Lines 8025 8025
Branches 1623 1623
=======================================
Hits 7629 7629
Misses 396 396
🚀 New features to boost your workflow:
|
david-luna
reviewed
Apr 7, 2025
david-luna
changed the title
getStringFromEnv instead of process.envgetStringFromEnv instead of process.env
Co-authored-by: David Luna <[email protected]>
svetlanabrennan
approved these changes
Apr 8, 2025
trentm
approved these changes
Apr 9, 2025
experimental/packages/otlp-exporter-base/src/configuration/otlp-http-env-configuration.ts
Show resolved
Hide resolved
experimental/packages/otlp-exporter-base/src/configuration/otlp-http-env-configuration.ts
Outdated
Show resolved
Hide resolved
|
@weyert do you have time to address the changes proposed? I would be happy to merge this PR once done and the conflict is resolved. |
|
Please fix comments and conflicts and we can merge this :) |
This was referenced Sep 2, 2025
Joozty
pushed a commit
to Joozty/opentelemetry-js
that referenced
this pull request
Sep 9, 2025
…ess.env` (open-telemetry#5594) Signed-off-by: Weyert de Boer <[email protected]> Co-authored-by: David Luna <[email protected]> Co-authored-by: Trent Mick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Updates the code to user the helper utilities to retrieve environment variable values
Fixes #5561
Short description of the changes
Used the
getStringFromEnv-helper function instead ofprocess.envType of change
Please delete options that are not relevant.
How Has This Been Tested?
I have ran the relevant unit tests to verify the tests still pass as expected.
Checklist: