Skip to content

fix: update nodejs readme with missing step #1650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tylerbenson merged 2 commits into from
Jan 13, 2025
Merged

fix: update nodejs readme with missing step #1650

tylerbenson merged 2 commits into from
Jan 13, 2025

Conversation

@garysassano
Copy link
Member

@garysassano garysassano commented Jan 7, 2025

No description provided.

@garysassano garysassano requested a review from a team as a code owner January 7, 2025 20:53
@tylerbenson
Copy link
Member

tylerbenson commented Jan 13, 2025

@serkan-ozal any idea why check-links is failing?

@serkan-ozal
Copy link
Contributor

serkan-ozal commented Jan 13, 2025 •
edited
Loading

@tylerbenson

I am not sure check-links has been working before. Because as far as I see, it tries to run npm install command at the root of the repository, but there is no package.json there.

Maybe this line should be npm install markdown-link-check: https://github.com/open-telemetry/opentelemetry-lambda/blob/main/.github/workflows/check-links.yaml#L38

@RichardChukwu any idea why as the author of this workflow? Maybe, you forgot to add package.json to the PR before?

@tylerbenson
Copy link
Member

tylerbenson commented Jan 13, 2025

Ok, I'll ignore for now then.

@tylerbenson tylerbenson merged commit 2f373c8 into open-telemetry:main Jan 13, 2025
11 of 12 checks passed
mpuigdomenchSage pushed a commit to Sage/opentelemetry-lambda that referenced this pull request Jan 28, 2025
@garysassano @mpuigdomenchSage
fix: update nodejs readme with missing step (open-telemetry#1650)
634a6ed
@tylerbenson tylerbenson added the documentation Improvements or additions to documentation label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tylerbenson tylerbenson tylerbenson approved these changes

@serkan-ozal serkan-ozal serkan-ozal approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@garysassano @tylerbenson @serkan-ozal