-
Notifications
You must be signed in to change notification settings - Fork 228
Feat/nodejs/add auto instrumentations #1724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/nodejs/add auto instrumentations #1724
Conversation
…ions list" This reverts commit 763ef0c.
|
Separate comment for readability. After discussion with maintainers I've reverted the change where we alter the default instrumentations. This PR's purpose is only to support more out-of-the-box instrumentation and therefore we don't want it to be breaking. Removing defaults is, however, breaking so that will be a separate PR. |
|
As requested I also ran some quick tests to see impact on the actual OTEL wrapper initialization times.
These are the results after running 40 times (data in ms):
Here's the raw data: otel_wrapper_init_times_ms.csv Sample size n=40 may not be a lot. But these results do look assuring that the changes have minimal to no impact on wrapper initialization time. If further testing is required, I can of course alter the parameters and/or sample size to get more data. |
…feat/nodejs/add-auto-instrumentations
|
Fixed @serkan-ozal's comment about |
pragmaticivan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Btw, it seems the failures in check-links are legit, so we probably need to fix these links later in a new PR. Not related to this PR though. |

This PR fixes #1723, fixes #1600, fixes #1611
Added all the instrumentations that exist in the otel auto-instrumentations-node metapackage. Also removed most of the defaults. Right now only defaults (besides aws-lambda and aws sdk instrumentation) left are:
I can see 2 possible changes to this:
As of now the PR is still a work in progress. I'm still working on a proposal to refactor the logic for the dynamic imports. As the wrapper code has gotten a bit bloated with all newly added instrumentations: wrapper.tsAlso, as this was discussed in the otel faas working group. The changes do indeed not noticably impact package size and cold starts. After adding the extra instrumentation packages, the package size increased by ~40KB. I ran some tests and noticed no difference in cold start times.