Skip to content

Make Python autoinstrumentation envvar injection consistent with other languages by using appendOrReplace #4565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
BradenChapman wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Make Python autoinstrumentation envvar injection consistent with other languages by using appendOrReplace #4565

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/instrumentation/sdk.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ func (i *sdkInjector) injectDefaultNodeJSEnvVars(pod corev1.Pod, index int) core
// injectDefaultPythonEnvVars injects default environment variables for Python.
func (i *sdkInjector) injectDefaultPythonEnvVars(pod corev1.Pod, index int) corev1.Pod {
container := &pod.Spec.Containers[index]
container.Env = appendIfNotSet(container.Env, getDefaultPythonEnvVars()...)
container.Env = appendOrReplace(container.Env, getDefaultPythonEnvVars()...)
return pod
}

Expand Down