Fixes for PHPUnit errors in the Curl instrumentation library #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #371 +/- ##
============================================
+ Coverage 81.68% 82.15% +0.46%
- Complexity 1741 1865 +124
============================================
Files 133 137 +4
Lines 7307 7698 +391
============================================
+ Hits 5969 6324 +355
- Misses 1338 1374 +36 Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
smaddock
changed the title
intuibase
approved these changes
Jun 4, 2025
bobstrecansky
approved these changes
Jun 11, 2025
github-project-automation
bot
moved this from In Progress
to Done
in PHP Prioritized Backlog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Curl
There are intermittent PHPUnit errors in the Instrumentation/Curl library for the
curl_multiintegration tests stating the asserted span count is 1 instead of 2. Tracking it down, the WeakReference the for the cURL handle sub-span was sometimes being destroyed too early, causingfinishMultiSpan()to bail, the scope to never detach, and the span to never be added to storage. I believe it is due to:Changing the sub-span to be directly assigned to the
handlesWeakMap resolves the test failures.make allpasses with this change, but I do not know if there are other consequences.cc @intuibase
Edit: split OpenAIPHP component to #375