Fix for PHPUnit error in the OpenAIPHP instrumentation library #375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettmc
approved these changes
May 21, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #375 +/- ##
============================================
+ Coverage 81.68% 81.82% +0.13%
- Complexity 1741 1775 +34
============================================
Files 133 135 +2
Lines 7307 7455 +148
============================================
+ Hits 5969 6100 +131
- Misses 1338 1355 +17 Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
split of #371
OpenAIPHP
There is a PHPUnit error in the Instrumentation/OpenAIPHP library for the
openai_operation(images) integration tests statingmethod_existsis being passed a null value.OpenAI\Responses\Images\CreateResponsedefines a nullable$usageproperty, so in the instrumentation library'srecordUsage(), I believe it is due to:Adding an additional test to the conditional in
recordUsage()resolves the test failure.make allpasses with this change, but I do not know if there are other consequences.cc @cedricziel @brettmc @agoallikmaa