Skip to content

Conversation

@weslenteche
Copy link
Contributor

No description provided.

@weslenteche weslenteche requested a review from a team as a code owner June 7, 2025 02:33
@codecov
Copy link

codecov bot commented Jun 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.14%. Comparing base (c15360b) to head (e9a2512).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #384      +/-   ##
============================================
+ Coverage     81.33%   82.14%   +0.81%     
- Complexity     1308     1801     +493     
============================================
  Files           116      137      +21     
  Lines          5630     7594    +1964     
============================================
+ Hits           4579     6238    +1659     
- Misses         1051     1356     +305     
Flag Coverage Δ
Aws 92.59% <ø> (ø)
Context/Swoole 0.00% <ø> (?)
Instrumentation/CakePHP 20.40% <ø> (ø)
Instrumentation/CodeIgniter 73.55% <ø> (ø)
Instrumentation/Doctrine 92.72% <ø> (ø)
Instrumentation/ExtAmqp 88.48% <ø> (ø)
Instrumentation/ExtRdKafka 86.11% <ø> (ø)
Instrumentation/Guzzle 69.13% <ø> (ø)
Instrumentation/HttpAsyncClient 78.04% <ø> (ø)
Instrumentation/IO 70.68% <ø> (ø)
Instrumentation/Laravel 63.91% <ø> (ø)
Instrumentation/MongoDB 74.28% <ø> (ø)
Instrumentation/MySqli 95.81% <ø> (ø)
Instrumentation/OpenAIPHP 87.21% <ø> (ø)
Instrumentation/PDO 94.21% <ø> (?)
Instrumentation/Psr14 76.47% <ø> (ø)
Instrumentation/Psr15 89.15% <ø> (?)
Instrumentation/Psr16 97.50% <ø> (ø)
Instrumentation/Psr18 77.46% <ø> (?)
Instrumentation/Psr3 67.01% <ø> (?)
Instrumentation/Psr6 97.61% <ø> (ø)
Instrumentation/ReactPHP 99.28% <ø> (ø)
Instrumentation/Slim 86.11% <ø> (?)
Instrumentation/Symfony 84.74% <ø> (ø)
Instrumentation/Yii 77.50% <ø> (ø)
Logs/Monolog 100.00% <ø> (ø)
Propagation/Instana 98.11% <ø> (ø)
Propagation/ServerTiming 100.00% <ø> (?)
Propagation/TraceResponse 100.00% <ø> (?)
ResourceDetectors/Azure 91.66% <ø> (ø)
ResourceDetectors/Container 93.02% <ø> (ø)
Sampler/RuleBased 33.51% <ø> (ø)
Shims/OpenTracing 92.45% <ø> (ø)
Symfony 87.81% <ø> (ø)
Utils/Test 87.53% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 21 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c15360b...e9a2512. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@smaddock
Copy link
Contributor

smaddock commented Jun 7, 2025

If the goal is consistency for all contrib packages, here are a few more:

  • the propagatora have _register.php files that can be added to composer > autoload > files
  • the Azure resource detector can be added to composer > autoload > psr4, composer > autoload > files, and composer > replace
  • the rule-based sampler can be added to composer > autoload > psr4 and composer > replace

@brettmc
Copy link
Contributor

brettmc commented Jun 10, 2025

If the goal is consistency for all contrib packages

@weslenteche will you include those other suggestions? If not, I'm happy to accept as-is

@smaddock
Copy link
Contributor

@brettmc I can do a separate PR for those

@brettmc brettmc merged commit 105e773 into open-telemetry:main Jun 11, 2025
137 of 140 checks passed
@weslenteche weslenteche deleted the update-composer branch June 14, 2025 12:29
@weslenteche
Copy link
Contributor Author

If the goal is consistency for all contrib packages

@weslenteche will you include those other suggestions? If not, I'm happy to accept as-is

Hi everyone, the last week was a bit busy at work and I ended up not having time to adapt the suggestions from @smaddock

Thank you very much for following up on the suggestions in other pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants