NoOpTracerProvider test case for botocore instrumentation #2846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzchen
approved these changes
Sep 4, 2024
|
Please rebase and allow maintainers commits. |
emdneto
approved these changes
Sep 11, 2024
|
@Sunilwali679 please setup pre-commit (and fix linting) and rebase |
Signed-off-by: Wali, Sunil Shidrayi <[email protected]>
Sunilwali679
force-pushed
the
AddsNoOpTracerProvider-testcasebotocore
branch
from
5732e37 to
678e654
Compare
|
@xrmx Done the rebase and submitted for review |
It looks like you missed the pre-commit setup 😅 |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds NoOpTracerProvider test cases for botocore instrumentation.
Fixes #988
How Has This Been Tested?
tox -e test-instrumentation-botocore
Does This PR Require a Core Repo Change?