Skip to content

pymssql: fix entry_point for auto-instrumentation #3214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 28, 2025
Merged

pymssql: fix entry_point for auto-instrumentation #3214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e216e5
fix pymssql entry_point for auto-instrumentation
emdneto Jan 28, 2025
006a8cc
Merge branch 'main' into pymssql-fix
xrmx Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion instrumentation/opentelemetry-instrumentation-pymssql/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ instruments = [
]

[project.entry-points.opentelemetry_instrumentor]
pymssql = "opentelemetry.instrumentation.pymssql:pymssqlInstrumentor"
pymssql = "opentelemetry.instrumentation.pymssql:PyMSSQLInstrumentor"

[project.urls]
Homepage = "https://github.com/open-telemetry/opentelemetry-python-contrib/tree/main/instrumentation/opentelemetry-instrumentation-pymssql"
Expand Down
13 changes: 13 additions & 0 deletions instrumentation/opentelemetry-instrumentation-pymssql/tests/test_pymssql_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
from opentelemetry.instrumentation.pymssql import PyMSSQLInstrumentor
from opentelemetry.sdk import resources
from opentelemetry.test.test_base import TestBase
from opentelemetry.util._importlib_metadata import entry_points


def mock_connect(*args, **kwargs):
Expand Down Expand Up @@ -182,3 +183,15 @@ def test_uninstrument_connection(self):

spans_list = self.memory_exporter.get_finished_spans()
self.assertEqual(len(spans_list), 1)

def test_load_entry_point(self):
self.assertIs(
next(
iter(
entry_points(
group="opentelemetry_instrumentor", name="pymssql"
)
)
).load(),
PyMSSQLInstrumentor,
)
Loading