Skip to content

Conversation

@xrmx
Copy link
Contributor

@xrmx xrmx commented Mar 6, 2025

Description

Instead of expecting an entry in a specific bucket, just sum all of them and assert we have the correct number of entries.
Fixes #3320

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tox -e py318-test-instrumentation-urllib

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

Instead of expecting an entry in a specific bucket, just sum all of them
and assert we have the correct number of entries.
@xrmx xrmx added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 6, 2025
@xrmx xrmx requested a review from emdneto March 6, 2025 08:26
@github-actions github-actions bot requested a review from shalevr March 6, 2025 08:29
@xrmx xrmx changed the title urllib: don't assume we control the bucket metrics data point get in urllib: don't assume we control the bucket metrics data points get in Mar 6, 2025
@shalevr shalevr enabled auto-merge (squash) March 6, 2025 12:05
@shalevr shalevr merged commit c0132c6 into open-telemetry:main Mar 6, 2025
712 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

urllib: flaky test with python 3.8

3 participants