Skip to content

requests: migrate from SpanAttributes #3493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 19, 2025
Merged

requests: migrate from SpanAttributes #3493

merged 5 commits into from
May 19, 2025

Conversation

@IAmPrajna
Copy link
Contributor

Description

Replaces usage of SpanAttributes with opentelemetry.semconv.attributes.http_attributes and opentelemetry.semconv._incubating.attributes .

Refs #3475

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • tox

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 11, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@IAmPrajna
B
67dbee2 
reverted to SpanAttributes for the SCHEMA_URL
@xrmx xrmx changed the title ref: migrate from SpanAttributes requests: migrate from SpanAttributes May 15, 2025
xrmx
xrmx reviewed May 15, 2025
View reviewed changes
Copy link
Contributor

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nits but the attributes changes look fine.

@xrmx xrmx moved this to Reviewed PR that needs fixing in @xrmx's Python PR digest May 15, 2025
@IAmPrajna
Copy link
Contributor Author

I have sorted the imports. Can you please re-run the tests ? @xrmx

@xrmx xrmx enabled auto-merge (squash) May 19, 2025 08:19
@xrmx xrmx mentioned this pull request May 19, 2025
Open
41 tasks
@xrmx xrmx merged commit f211828 into open-telemetry:main May 19, 2025
718 of 720 checks passed
@github-project-automation github-project-automation bot moved this from Reviewed PR that needs fixing to Done in @xrmx's Python PR digest May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xrmx xrmx xrmx approved these changes

@emdneto emdneto emdneto approved these changes

Assignees

No one assigned

Labels

None yet

Projects

@xrmx's Python PR digest
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@IAmPrajna @xrmx @emdneto