fix: improve Ethon exception handling #1634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mspletz
requested review from
a team,
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
kaylareopelle,
mwear,
plantfansam,
robbkidd,
robertlaurin,
simi and
xuan-cao-swi
as code owners
mspletz
changed the title
Contributor
|
Hi @mspletz! Thanks for your contribution! There's a few Rubocop failures that need to be addressed to get the tests to pass. |
Contributor
Author
|
👋 I believe I fixed the rubocop failures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This pull request improves error handling for Ethon instrumentation by ensuring that spans are properly closed and marked as errors when an exception occurs during the HTTP request execution, before the
completemethod is called.Why
Today, we've observed that some
ethon.clienthttp POST spans from this otel library continue unexpectedly for a long time (up to 13 hours). This has led us to believe that there are occasions where theperformmethod ran into an unhandled exception and never properly made it to thecompletemethod to close the span.