chore: add Rubocop additional linter #1836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuan-cao-swi
requested review from
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
kaylareopelle,
mwear,
plantfansam,
robbkidd and
robertlaurin
as code owners
Contributor
kaylareopelle
left a comment
kaylareopelle
left a comment
There was a problem hiding this comment.
Thanks for putting this together, @xuan-cao-swi! I'm a little confused about your comment in the PR description about the Appraisals. It looks like they ran fine in the CI? I know we talked about this in the SIG, but I forgot -- do we need to consider that Appraisal issue a blocker before this is safe to merge?
kaylareopelle
approved these changes
Apr 22, 2025
Contributor
kaylareopelle
left a comment
kaylareopelle
left a comment
There was a problem hiding this comment.
Thank you! I'm going to change the conventional commit style to a chore for this PR so that it doesn't trigger a release, as the changes are largely style-based.
kaylareopelle
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to open-telemetry/opentelemetry-ruby-contrib#1392
I suggest use shared gamefile that contain all development dependencies (e.g. rubocop) since they are not part of gem bundle (i.e. only for internal use). Appraisal won't work with
eval_gemfilebut they have one active PR that will introduce the support foreval_gemfile. For gems (mostly exporter) that use appraisal, the development dependencies are in gemspec.