Skip to content

Conversation

@lalitb
Copy link
Member

@lalitb lalitb commented Oct 24, 2024

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb requested a review from a team as a code owner October 24, 2024 23:46
@codecov
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 79.5%. Comparing base (4a405fd) to head (f99756a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-sdk/src/metrics/pipeline.rs 0.0% 5 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2244   +/-   ##
=====================================
  Coverage   79.5%   79.5%           
=====================================
  Files        121     121           
  Lines      20938   20938           
=====================================
  Hits       16656   16656           
  Misses      4282    4282           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

// If an existing instrument with the same name but different attributes is found,
// log a warning with details about the conflicting metric stream definitions.
otel_warn!(
name: "Instrument.DuplicateMetricStreamDefinitions",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what is the action end users are expected to do when they see this.. If this is only for sdk maintainers to debug, then lets use debug level only. If keeping at Warn, then it should be actionable/descriptive.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@lalitb lalitb merged commit 3bc9b3d into open-telemetry:main Oct 27, 2024
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants