Skip to content

Global error handler cleanup - Metrics Pipeline #2244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lalitb merged 6 commits into from
Oct 27, 2024
Merged

Global error handler cleanup - Metrics Pipeline #2244

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cfd4ef9
initial commit
lalitb Oct 24, 2024
96c3328
Merge branch 'main' into pipeline-metrics-internal-log
lalitb Oct 25, 2024
31b738b
Merge branch 'main' into pipeline-metrics-internal-log
lalitb Oct 25, 2024
2154a16
use otel_debug
lalitb Oct 26, 2024
cc331ad
Merge branch 'main' into pipeline-metrics-internal-log
lalitb Oct 27, 2024
f99756a
lint
lalitb Oct 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions opentelemetry-sdk/src/metrics/pipeline.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,8 @@ use std::{
};

use opentelemetry::{
global,
metrics::{MetricsError, Result},
InstrumentationScope, KeyValue,
otel_debug, InstrumentationScope, KeyValue,
};

use crate::{
Expand Down Expand Up @@ -413,15 +412,18 @@ where
if existing == id {
return;
}

global::handle_error(MetricsError::Other(format!(
"duplicate metric stream definitions, names: ({} and {}), descriptions: ({} and {}), kinds: ({:?} and {:?}), units: ({:?} and {:?}), and numbers: ({} and {})",
// If an existing instrument with the same name but different attributes is found,
// log a warning with details about the conflicting metric stream definitions.
otel_debug!(
name: "Instrument.DuplicateMetricStreamDefinitions",
Copy link
Member

@cijothomas cijothomas Oct 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what is the action end users are expected to do when they see this.. If this is only for sdk maintainers to debug, then lets use debug level only. If keeping at Warn, then it should be actionable/descriptive.

Copy link
Member Author

@lalitb lalitb Oct 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

message = "duplicate metric stream definitions",
reason = format!("names: ({} and {}), descriptions: ({} and {}), kinds: ({:?} and {:?}), units: ({:?} and {:?}), and numbers: ({} and {})",
existing.name, id.name,
existing.description, id.description,
existing.kind, id.kind,
existing.unit, id.unit,
existing.number, id.number,
)))
existing.number, id.number,)
);
}
}
}
Expand Down